-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-existent display_name
field from the UserProfileUserInfo
interface.
#139091
Remove non-existent display_name
field from the UserProfileUserInfo
interface.
#139091
Conversation
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
As of elastic/elasticsearch#84257,
display_name
is no longer returned from the Elasticsearch User Profiles API endpoints as it was decided that editabledisplay_name
isn't needed at the moment.The synthetic
display_name
we render as a human readable user "identifier" follows this logicuser.full_name (optional) || user.email (optional) || user.username (required)
. This PR exposesgetUserDisplayName
function that acceptsUserProfile
orUser
instances and returns the most suitable display name. Here is the context for this change shared by @MichaelMarcialis:cc @jonathan-buttner