Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Remove usage of savedObjects API #138997

Closed
wants to merge 2 commits into from
Closed

[Discover] Remove usage of savedObjects API #138997

wants to merge 2 commits into from

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Aug 17, 2022 •
edited
Loading

Addresses #91715

Steps to test it:

  • On Discover page create a new rule via "Alert" top menu item
  • Navigate to Stack Management > Rules and Connectors
  • Open your rule
  • Press on "Open in app" link at the top => it will redirect you back to Discover

@jughosta jughosta added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.5.0 labels Aug 17, 2022
@jughosta jughosta self-assigned this Aug 17, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 17, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / IndexPatterns savedObjectToSpec

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 464.4KB 464.4KB -56.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 42.1KB 42.1KB +80.0B
Unknown metric groups

API count

id before after diff
data 3114 3116 +2
dataViews 960 963 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta closed this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jughosta @kibana-ci