[TSVB] Greater Than or Equal to Interval Pattern #13872
Conversation
simianhacker
added
Feature:TSVB
|
We're eventually going to need to put together documentation for this new functionality. No one is going to know what this option is and that it's available (#13433). To start we could at least modify the interval label to include a >= example |
There was a problem hiding this comment.
Not sure if this >= is the way to go to satisfy this use-case. This approach is not very discoverable and is going to require additional documentation. It is also different from all the other time-formatting in e.g. timelion and Visualize.
imo, the behavior is basically a modifier for the auto duration setting. It ensures you cannot exceed the minimum threshold.
If the selection is auto, could we not have an input for a modifier that says something like: never smaller than: 1m/1w/.... I think it would better communicate this is actually the auto-interval setting.
This is more of a usability aspect, so @alexfrancoeur, feel free to call one way or the other.
Could you also add some tests for this?
|
++ I agree with @thomasneirynck it is certainly easier to understand with an additional input box if |
|
The problem with adding additional UI elements is that this component is reused in the series options as well. If you think real estate in the "Panel Config" is an issue, the real estate in the"Series Options" is even more limited. I don't think this use case is going to be widely adopted, most people will just use |
* Create new interval pattern for specifying greater than or equal to a bucket size * Updating label to add >=1m example * Adding test case for gteAutoMatch
* Create new interval pattern for specifying greater than or equal to a bucket size * Updating label to add >=1m example * Adding test case for gteAutoMatch
This PR adds a new interval pattern to TSVB allowing the user to specify an index pattern that is greater than or equal to a specified bucket. For example if the user enters
>=1m, TSVB will calculate theautobucket size for the time period. If that bucket is less than1mthen it will create1mbuckets. If it's greater then it will use theautogenerated bucket. This is really useful when collecting metrics at 1m intervals and you don't want to user to zoom in beyond the resolution of the data.Before:
After:
This PR also removes the interval validation on the string only. It still checks to make sure you're not specifying more buckets then the system can handle.