[build] Update copyAll implementation #138692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Team:Operations
jbudz
commented
Aug 12, 2022
| @@ -131,13 +131,6 @@ export async function runDockerGenerator( | |||
| dockerBuildDir | |||
| ); | |||
|
|
|||
| if (flags.ironbank) { | |||
There was a problem hiding this comment.
This wasn't used, and cpy throws errors if nothing matches. I think that's a reasonable API change, but can catch it if there's any concerns.
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
approved these changes
Aug 12, 2022
kibanamachine
added
v8.5.0
backport:skip
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
* [build] Update copyAll implementation * remove unused copy
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
Jun 27, 2023
* [build] Update copyAll implementation * remove unused copy (cherry picked from commit 339f906) # Conflicts: # src/dev/build/lib/fs.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
Jun 28, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [[build] Update copyAll implementation (#138692)](#138692) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jonathan Budzenski","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-08-12T11:38:22Z","message":"[build] Update copyAll implementation (#138692)\n\n* [build] Update copyAll implementation\r\n\r\n* remove unused copy","sha":"339f9068fc068ee0f7312206ace5acd7426a3478","branchLabelMapping":{"^v8.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","v8.5.0"],"number":138692,"url":"https://github.com/elastic/kibana/pull/138692","mergeCommit":{"message":"[build] Update copyAll implementation (#138692)\n\n* [build] Update copyAll implementation\r\n\r\n* remove unused copy","sha":"339f9068fc068ee0f7312206ace5acd7426a3478"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.5.0","labelRegex":"^v8.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/138692","number":138692,"mergeCommit":{"message":"[build] Update copyAll implementation (#138692)\n\n* [build] Update copyAll implementation\r\n\r\n* remove unused copy","sha":"339f9068fc068ee0f7312206ace5acd7426a3478"}}]}] BACKPORT--> --------- Co-authored-by: Jonathan Budzenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vinyl-fs is not updated frequently and there are more performant options now. This implementation reduces the copy source files task from ~50s to <10s.
Before: https://buildkite.com/elastic/kibana-on-merge/builds/19797#01828f2a-a628-425f-949d-b680c1f8bca1/198-224
After: https://buildkite.com/elastic/kibana-pull-request/builds/64706#01828fc1-ecd8-4881-9db9-9ae27fd5fa3d/207-233