[ML] Explain Log Rate Spikes: Extended Functional tests. #138661

walterra · 2022-08-11T18:23:53Z

Summary

Part of #136265, #133871.

Adds functional tests that use the histogram brushes and run an analysis.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-08-12T12:33:31Z

Pinging @elastic/ml-ui (:ml)

walterra · 2022-08-12T12:52:10Z

Running flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1032

Finished with 50 successful runs!

x-pack/packages/ml/aiops_components/src/progress_controls/progress_controls.tsx

x-pack/packages/ml/aiops_components/src/dual_brush/dual_brush.tsx

x-pack/test/functional/services/aiops/explain_log_rate_spikes_analysis_table.ts

walterra · 2022-08-12T16:50:17Z

@elasticmachine merge upstream

pheyos

Great to see these extended functional tests coming! 🎉
Left a few comments.

x-pack/test/functional/apps/aiops/explain_log_rate_spikes.ts

x-pack/test/functional/services/aiops/explain_log_rate_spikes.ts

x-pack/test/functional/services/aiops/explain_log_rate_spikes_analysis_table.ts

…ng histogram bar.

walterra · 2022-08-17T11:41:21Z

@pheyos Thanks for the feedback! Ready for another look now.

pheyos

LGTM

kibana-ci · 2022-08-17T13:09:29Z

💚 Build Succeeded

Buildkite Build
Commit: 97ba29d

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	478.0KB	478.8KB	+866.0B

History

💔 Build #65664 failed 1f9f454
💚 Build #65289 succeeded ff40599
💚 Build #64899 succeeded 414f4dd
💚 Build #64890 succeeded 1abd6fd
💚 Build #64844 succeeded ef3a902
💚 Build #64783 succeeded 9be7234

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

qn895 · 2022-08-17T15:16:25Z

LGTM 🎉

walterra · 2022-08-31T12:52:09Z

💚 All backports created successfully

Status	Branch	Result
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

) Adds functional tests that use the histogram brushes and run an analysis. (cherry picked from commit 148b48f)

…139822) Adds functional tests that use the histogram brushes and run an analysis. (cherry picked from commit 148b48f)

) Adds functional tests that use the histogram brushes and run an analysis.

walterra added 3 commits August 11, 2022 15:39

[ML] Extend functional tests to run analysis.

b7c6bef

[aiops] WIP: Brush tests.

608032e

[aiops] Adjust brushes and assert analysis results.

e724c58

walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 11, 2022

walterra self-assigned this Aug 11, 2022

[aiops] Improve assertions for adjusted brush.

1bfabfa

This was referenced Aug 12, 2022

[ML] Explain log rate spikes: MVP 8.4 improvements. #136265

Closed

[ML] Increase Test Coverage 8.4.0 #133871

Closed

[aiops] tweak assertions.

9be7234

walterra requested review from qn895 and pheyos August 12, 2022 12:33

walterra marked this pull request as ready for review August 12, 2022 12:33

walterra requested a review from a team as a code owner August 12, 2022 12:33

qn895 reviewed Aug 12, 2022

View reviewed changes

x-pack/packages/ml/aiops_components/src/progress_controls/progress_controls.tsx Show resolved Hide resolved

qn895 reviewed Aug 12, 2022

View reviewed changes

x-pack/packages/ml/aiops_components/src/dual_brush/dual_brush.tsx Show resolved Hide resolved

qn895 reviewed Aug 12, 2022

View reviewed changes

x-pack/test/functional/services/aiops/explain_log_rate_spikes_analysis_table.ts Outdated Show resolved Hide resolved

qn895 reviewed Aug 12, 2022

View reviewed changes

x-pack/test/functional/services/aiops/explain_log_rate_spikes_analysis_table.ts Outdated Show resolved Hide resolved

walterra added 2 commits August 12, 2022 16:27

[aiops] Add comment to explain string manipulation.

9f8d948

[aiops] Remove unused methods.

ef3a902

walterra added ci:build-cloud-image ci:cloud-deploy Create or update a Cloud deployment labels Aug 12, 2022

Merge branch 'main' into ml-aiops-functional-tests-2

1abd6fd

walterra removed ci:build-cloud-image ci:cloud-deploy Create or update a Cloud deployment labels Aug 12, 2022

walterra requested a review from peteharverson August 16, 2022 06:56

walterra added backport pending backport:skip This commit does not require backporting labels Aug 17, 2022

pheyos reviewed Aug 17, 2022

View reviewed changes

walterra added 8 commits August 17, 2022 12:41

Merge branch 'main' into ml-aiops-functional-tests-2

9da72ec

[aiops] set chart debug flag to false after test.

d5b1407

[aiops] Assert if histogram brushes interface is present after clicki…

4087ba8

…ng histogram bar.

[aiops] Fix method names.

e0ca68c

[aiops] Remove 'before' from variable names.

2d7291e

[aiops] Add comment to explain timestamp to px transformation.

f8fec5a

[aiops] Simplify offset calculation.

7e45cdd

[aiops] Remove unused types and arguments.

1f9f454

[aiops] Fix i18n.

97ba29d

pheyos approved these changes Aug 17, 2022

View reviewed changes

qn895 approved these changes Aug 17, 2022

View reviewed changes

walterra merged commit 148b48f into elastic:main Aug 17, 2022

walterra deleted the ml-aiops-functional-tests-2 branch August 17, 2022 15:18

walterra added v8.4.2 and removed backport:skip This commit does not require backporting ci:build-cloud-image v8.4.0 labels Aug 31, 2022

walterra mentioned this pull request Aug 31, 2022

[8.4] [ML] Explain Log Rate Spikes: Extended Functional tests. (#138661) #139822

Merged

walterra added a commit to walterra/kibana that referenced this pull request Aug 31, 2022

[ML] Explain Log Rate Spikes: Extended Functional tests. (elastic#138661

df08fd4

) Adds functional tests that use the histogram brushes and run an analysis. (cherry picked from commit 148b48f)

walterra removed the backport pending label Aug 31, 2022

walterra added a commit that referenced this pull request Aug 31, 2022

[ML] Explain Log Rate Spikes: Extended Functional tests. (#138661) (#…

cabe529

…139822) Adds functional tests that use the histogram brushes and run an analysis. (cherry picked from commit 148b48f)

Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022

[ML] Explain Log Rate Spikes: Extended Functional tests. (elastic#138661

868ad57

) Adds functional tests that use the histogram brushes and run an analysis.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Explain Log Rate Spikes: Extended Functional tests. #138661

[ML] Explain Log Rate Spikes: Extended Functional tests. #138661

walterra commented Aug 11, 2022 •

edited

Loading

elasticmachine commented Aug 12, 2022

walterra commented Aug 12, 2022 •

edited

Loading

walterra commented Aug 12, 2022

pheyos left a comment

walterra commented Aug 17, 2022

pheyos left a comment

kibana-ci commented Aug 17, 2022

qn895 commented Aug 17, 2022

walterra commented Aug 31, 2022

[ML] Explain Log Rate Spikes: Extended Functional tests. #138661

[ML] Explain Log Rate Spikes: Extended Functional tests. #138661

Conversation

walterra commented Aug 11, 2022 • edited Loading

Summary

Checklist

elasticmachine commented Aug 12, 2022

walterra commented Aug 12, 2022 • edited Loading

walterra commented Aug 12, 2022

pheyos left a comment

Choose a reason for hiding this comment

walterra commented Aug 17, 2022

pheyos left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 17, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

qn895 commented Aug 17, 2022

walterra commented Aug 31, 2022

💚 All backports created successfully

Questions ?

walterra commented Aug 11, 2022 •

edited

Loading

walterra commented Aug 12, 2022 •

edited

Loading