Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Lens poc #138594

Closed
wants to merge 20 commits into from
Closed

[Discover] Lens poc #138594

wants to merge 20 commits into from

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 11, 2022

Summary

This is an experimental PR integrating Lens in Discover to replace its histogram.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kertal kertal added the Feature:Discover Discover Application label Aug 11, 2022
@kertal kertal self-assigned this Aug 11, 2022
@kertal kertal mentioned this pull request Aug 12, 2022
5 tasks
@kertal kertal mentioned this pull request Sep 28, 2022
9 tasks
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 11, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #9 / a11y tests using flights sample data Filter panel a11y test on enable all filters view
  • [job] [logs] FTR Configs #27 / apis management index lifecycle management nodes list should return the list of ES node for each custom attributes
  • [job] [logs] FTR Configs #27 / apis management index lifecycle management nodes list should return the list of ES node for each custom attributes
  • [job] [logs] FTR Configs #9 / cases security and spaces enabled: basic Common assignees assigns a user to a case and retrieves the users profile
  • [job] [logs] FTR Configs #9 / cases security and spaces enabled: basic Common assignees assigns a user to a case and retrieves the users profile
  • [job] [logs] x-pack/test/detection_engine_api_integration/security_and_spaces/group1/config.ts / detection engine api security and spaces enabled - Group 1 Tests involving runtime fields of source indexes and the signals index "before all" hook in "Tests involving runtime fields of source indexes and the signals index"
  • [job] [logs] x-pack/test/detection_engine_api_integration/security_and_spaces/group1/config.ts / detection engine api security and spaces enabled - Group 1 Tests involving runtime fields of source indexes and the signals index "before all" hook in "Tests involving runtime fields of source indexes and the signals index"
  • [job] [logs] FTR Configs #2 / Discover alerting Search source Alert should navigate to discover via view in app link
  • [job] [logs] FTR Configs #2 / Discover alerting Search source Alert should navigate to discover via view in app link
  • [job] [logs] FTR Configs #28 / discover app indexpattern without timefield should adapt sidebar fields when switching
  • [job] [logs] FTR Configs #28 / discover app indexpattern without timefield should switch between with and without timefield using the browser back button
  • [job] [logs] Jest Tests #4 / Discover chart render with timefield with visualize permissions
  • [job] [logs] Jest Tests #4 / Discover chart render with timefield without visualize permissions
  • [job] [logs] Jest Tests #4 / Discover chart triggers ui action on click
  • [job] [logs] Jest Tests #4 / Discover component selected data view with time field displays chart toggle
  • [job] [logs] Jest Tests #4 / Discover component sidebar should be closed if discover:sidebarClosed is true
  • [job] [logs] Jest Tests #4 / Discover component sidebar should be opened if discover:sidebarClosed is false
  • [job] [logs] Jest Tests #4 / Discover component sidebar should be opened if discover:sidebarClosed was not set
  • [job] [logs] Jest Tests #4 / Discover component the saved search title h1 gains focus on navigate
  • [job] [logs] FTR Configs #18 / discover discover field visualize button should preserve query in lens
  • [job] [logs] FTR Configs #18 / discover Discover Saved Searches should unselect saved search when navigating to a 'new'
  • [job] [logs] FTR Configs #12 / discover/group1 discover test query should modify the time range when the histogram is brushed
  • [job] [logs] FTR Configs #12 / discover/group1 discover test query should modify the time range when the histogram is brushed
  • [job] [logs] Jest Tests #2 / embeddable should call onload after rerender and onData$ call
  • [job] [logs] Jest Tests #4 / Histogram renders correctly
  • [job] [logs] Jest Tests #4 / Histogram renders error correctly
  • [job] [logs] Jest Tests #4 / Histogram renders loading state correctly
  • [job] [logs] FTR Configs #16 / lens app - group 2 show underlying data should show the open button for a compatible saved visualization
  • [job] [logs] FTR Configs #16 / lens app - group 2 show underlying data should show the open button for a compatible saved visualization
  • [job] [logs] Jest Tests #2 / open in discover action compatibility check is incompatible if user cant access Discover app
  • [job] [logs] Jest Tests #2 / open in discover action navigates to discover when executed
  • [job] [logs] FTR Configs #38 / security APIs - PKI PKI authentication should reject API requests that use untrusted certificate
  • [job] [logs] FTR Configs #38 / security APIs - PKI PKI authentication should reject API requests that use untrusted certificate

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 555 548 -7
savedSearch - 11 +11
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 68 73 +5
savedSearch - 39 +39
total +44

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 463.3KB 463.3KB -6.0B
lens 1.2MB 1.2MB -9.8KB
total -9.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
discover 7 5 -2
savedSearch - 1 +1
total -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 29.1KB 25.4KB -3.6KB
lens 34.3KB 33.2KB -1.1KB
savedSearch - 4.7KB +4.7KB
visualizations 46.8KB 46.8KB +3.0B
total +34.0B
Unknown metric groups

API count

id before after diff
discover 84 89 +5
savedSearch - 39 +39
total +44

async chunk count

id before after diff
lens 14 13 -1

ESLint disabled in files

id before after diff
apm 14 13 -1
discover 2 1 -1
observability 6 5 -1
savedSearch - 1 +1
total -2

ESLint disabled line counts

id before after diff
apm 81 78 -3
discover 37 38 +1
enterpriseSearch 13 11 -2
observability 44 43 -1
synthetics 57 51 -6
ux 10 9 -1
total -12

Total ESLint disabled count

id before after diff
apm 95 91 -4
enterpriseSearch 13 11 -2
observability 50 48 -2
savedSearch - 1 +1
synthetics 63 57 -6
ux 13 12 -1
total -14

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal
Copy link
Member Author

kertal commented Jan 13, 2023

closing, since no longer relevant

@kertal kertal closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants