You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
Risk
Probability
Severity
Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.
Low
High
Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.
High
Low
Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.
Medium
High
Unit tests will verify that any feature flag or plugin combination still results in our service operational.
[job][logs] FTR Configs #9 / a11y tests using flights sample data Filter panel a11y test on enable all filters view
[job][logs] FTR Configs #27 / apis management index lifecycle management nodes list should return the list of ES node for each custom attributes
[job][logs] FTR Configs #27 / apis management index lifecycle management nodes list should return the list of ES node for each custom attributes
[job][logs] FTR Configs #9 / cases security and spaces enabled: basic Common assignees assigns a user to a case and retrieves the users profile
[job][logs] FTR Configs #9 / cases security and spaces enabled: basic Common assignees assigns a user to a case and retrieves the users profile
[job][logs] x-pack/test/detection_engine_api_integration/security_and_spaces/group1/config.ts / detection engine api security and spaces enabled - Group 1 Tests involving runtime fields of source indexes and the signals index "before all" hook in "Tests involving runtime fields of source indexes and the signals index"
[job][logs] x-pack/test/detection_engine_api_integration/security_and_spaces/group1/config.ts / detection engine api security and spaces enabled - Group 1 Tests involving runtime fields of source indexes and the signals index "before all" hook in "Tests involving runtime fields of source indexes and the signals index"
[job][logs] FTR Configs #2 / Discover alerting Search source Alert should navigate to discover via view in app link
[job][logs] FTR Configs #2 / Discover alerting Search source Alert should navigate to discover via view in app link
[job][logs] FTR Configs #28 / discover app indexpattern without timefield should adapt sidebar fields when switching
[job][logs] FTR Configs #28 / discover app indexpattern without timefield should switch between with and without timefield using the browser back button
[job][logs] Jest Tests #4 / Discover chart render with timefield with visualize permissions
[job][logs] Jest Tests #4 / Discover chart render with timefield without visualize permissions
[job][logs] Jest Tests #4 / Discover chart triggers ui action on click
[job][logs] Jest Tests #4 / Discover component selected data view with time field displays chart toggle
[job][logs] Jest Tests #4 / Discover component sidebar should be closed if discover:sidebarClosed is true
[job][logs] Jest Tests #4 / Discover component sidebar should be opened if discover:sidebarClosed is false
[job][logs] Jest Tests #4 / Discover component sidebar should be opened if discover:sidebarClosed was not set
[job][logs] Jest Tests #4 / Discover component the saved search title h1 gains focus on navigate
[job][logs] FTR Configs #18 / discover discover field visualize button should preserve query in lens
[job][logs] FTR Configs #18 / discover Discover Saved Searches should unselect saved search when navigating to a 'new'
[job][logs] FTR Configs #12 / discover/group1 discover test query should modify the time range when the histogram is brushed
[job][logs] FTR Configs #12 / discover/group1 discover test query should modify the time range when the histogram is brushed
[job][logs] Jest Tests #2 / embeddable should call onload after rerender and onData$ call
[job][logs] Jest Tests #4 / Histogram renders correctly
[job][logs] Jest Tests #4 / Histogram renders error correctly
[job][logs] Jest Tests #4 / Histogram renders loading state correctly
[job][logs] FTR Configs #16 / lens app - group 2 show underlying data should show the open button for a compatible saved visualization
[job][logs] FTR Configs #16 / lens app - group 2 show underlying data should show the open button for a compatible saved visualization
[job][logs] Jest Tests #2 / open in discover action compatibility check is incompatible if user cant access Discover app
[job][logs] Jest Tests #2 / open in discover action navigates to discover when executed
[job][logs] FTR Configs #38 / security APIs - PKI PKI authentication should reject API requests that use untrusted certificate
[job][logs] FTR Configs #38 / security APIs - PKI PKI authentication should reject API requests that use untrusted certificate
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an experimental PR integrating Lens in Discover to replace its histogram.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers