Disable edit tag "save changes" button if no changes have been made #138500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
hop-dev
changed the title
hop-dev
commented
Aug 10, 2022
| const initialName = useMemo(() => tag.name, []); | ||
|
|
||
| const initialTag = useMemo(() => tag, []); | ||
| const tagHasBeenModified = useMemo( |
There was a problem hiding this comment.
Seemed a shame to import lodash isEqual here to compare 3 properties of an object so kept it simple
rudolf
requested changes
Aug 11, 2022
|
@rudolf I've added the tests 👍 |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 12, 2022
…lastic#138500) (cherry picked from commit 945d456)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 12, 2022
…lastic#138500) (elastic#138714) (cherry picked from commit 945d456) Co-authored-by: Mark Hopkin <[email protected]>
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #138493 which was raised by Fleet QA.
In the edit tag modal, disable the "save changes" button until the user makes changes to the tag
save_changes_btn.mov