Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Update data view naming for locator #138423

Merged
merged 5 commits into from
Aug 12, 2022
Merged

[Discover] Update data view naming for locator #138423

merged 5 commits into from
Aug 12, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Aug 9, 2022

Summary

Remaining stuff from #132012

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.5.0 labels Aug 9, 2022
@dimaanj dimaanj self-assigned this Aug 9, 2022
@dimaanj dimaanj added the WIP Work in progress label Aug 9, 2022
@dimaanj dimaanj marked this pull request as ready for review August 10, 2022 10:43
@dimaanj dimaanj requested a review from a team as a code owner August 10, 2022 10:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj
Copy link
Contributor Author

dimaanj commented Aug 10, 2022

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Aug 11, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 29.1KB 29.1KB +28.0B
Unknown metric groups

API count

id before after diff
discover 84 85 +1

References to deprecated APIs

id before after diff
cloudSecurityPosture 0 1 +1
dataVisualizer 0 2 +2
discoverEnhanced 0 2 +2
fleet 19 20 +1
lens 10 11 +1
observability 3 4 +1
osquery 2 5 +3
synthetics 9 10 +1
total +12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

davismcphee
davismcphee approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review LGTM 👍

@kertal kertal self-requested a review August 11, 2022 16:53
kertal
kertal approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for adding the test, LGTM 👍

@dimaanj dimaanj merged commit 7927826 into elastic:main Aug 12, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 12, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@dimaanj @kibanamachine @Mpdreamz
[Discover] Update data view naming for locator (elastic#138423)
062624b 
* [Discover] update data view naming for locator

* [Discover] leave deprecated param

* [Discover] add legacy param test

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.5.0 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimaanj @elasticmachine @kibana-ci @kertal @davismcphee @kibanamachine