Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Fix stale brush props. #138272

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Aug 8, 2022

Summary

Part of #136265.

Fixes stale props that would cause a broken brush update when the overall time range selection changes.

Before:

image

After:

image

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 8, 2022
@walterra walterra requested a review from a team as a code owner August 8, 2022 14:15
@walterra walterra self-assigned this Aug 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Aug 8, 2022

Code LGTM 🎉

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@walterra walterra removed the request for review from alvarezmelissa87 August 10, 2022 11:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 477.7KB 477.9KB +244.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@jgowdyelastic jgowdyelastic self-requested a review August 10, 2022 14:57
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@walterra walterra merged commit 3ff5fb2 into elastic:main Aug 10, 2022
@walterra walterra deleted the ml-aiops-fix-stale-brush-props branch August 10, 2022 15:41
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
Fixes stale props that would cause a broken brush update when the overall time range selection changes.

(cherry picked from commit 3ff5fb2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
…elastic#138530)

Fixes stale props that would cause a broken brush update when the overall time range selection changes.

(cherry picked from commit 3ff5fb2)

Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants