Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain log rate spikes: Fix brush issues. #138113

Merged
merged 3 commits into from
Aug 4, 2022
Merged

[ML] Explain log rate spikes: Fix brush issues. #138113

merged 3 commits into from
Aug 4, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Aug 4, 2022 •
edited by kibanamachine
Loading

Summary

Part of #136265.

  • Fixes overlapping brush badges.
  • Adds missing tooltips to brush badges.

Previous:

aiops-brush-fixes-0002

After:

aiops-brush-fixes-0001

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 4, 2022
@walterra walterra self-assigned this Aug 4, 2022
@walterra walterra requested a review from a team as a code owner August 4, 2022 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Aug 4, 2022
Closed
34 tasks
darnautov
darnautov reviewed Aug 4, 2022
View reviewed changes
.../plugins/aiops/public/components/document_count_content/document_count_chart/brush_badge.tsx
Comment on lines +11 to +15
// @ts-ignore
import { formatDate } from '@elastic/eui/lib/services/format';

const DATE_FORMAT = 'YYYY-MM-DD';
const TIME_FORMAT = 'HH:mm:ss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a Kibana plugin fieldFormats that we should use, it takes into account Kibana settings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avid an extra refactoring in a bugfix PR, decided to postpone this change with the fieldFormats plugin for 8.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an item to the 8.5 meta issue: #138117

darnautov
darnautov approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 363 364 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 477.0KB 477.7KB +689.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiops 4.8KB 4.9KB +71.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

@walterra walterra merged commit 9512635 into elastic:main Aug 4, 2022
@walterra walterra deleted the ml-aiops-brush-fixes branch August 4, 2022 15:08
@kibanamachine kibanamachine mentioned this pull request Aug 4, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2022
@walterra
[ML] Explain log rate spikes: Fix brush issues. (elastic#138113)
6c7c4e6 
- Fixes overlapping brush badges.
- Adds missing tooltips to brush badges.

(cherry picked from commit 9512635)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 4, 2022
@kibanamachine @walterra
[ML] Explain log rate spikes: Fix brush issues. (elastic#138113) (ela…
f213348 
…stic#138134)

- Fixes overlapping brush badges.
- Adds missing tooltips to brush badges.

(cherry picked from commit 9512635)

Co-authored-by: Walter Rafelsberger <[email protected]>
@logeekal logeekal mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov darnautov approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @kibanamachine @darnautov @alvarezmelissa87