Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] [ML] Explain Log Rate Spikes: Fix loading behavior. (#137873) #137996

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.4:

Questions ?

Please refer to the Backport tool documentation

- Fixes API messages and loading state to always finish with 100% except when a user cancels the request.
- Fix to never apply loading={true} to the analysis table because it disables hovering events. To indicate loading we have the overall progress bar anyway.
- When the analysis returns no results, instead of an empty table and just the "no data" message, this now hides the table and displays an EuiEmptyPrompt.

(cherry picked from commit cd7578a)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 474.1KB 474.6KB +498.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@kibanamachine kibanamachine merged commit 468e805 into elastic:8.4 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants