[ML] Explain Log Rate Spikes: Fix error handling. #137947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
34 tasks
darnautov
reviewed
Aug 3, 2022
...plugins/aiops/public/components/explain_log_rate_spikes/explain_log_rate_spikes_analysis.tsx
Outdated
Show resolved
Hide resolved
...plugins/aiops/public/components/explain_log_rate_spikes/explain_log_rate_spikes_analysis.tsx
Outdated
Show resolved
Hide resolved
| @@ -45,6 +47,8 @@ export function streamReducer( | |||
| return cp; | |||
| }); | |||
| return { ...state, changePoints }; | |||
| case API_ACTION_NAME.ERROR: | |||
| return { ...state, errors: [...state.errors, action.payload] }; | |||
| case API_ACTION_NAME.RESET: | |||
| return initialState; | |||
| case API_ACTION_NAME.UPDATE_LOADING_STATE: | |||
There was a problem hiding this comment.
do you need to reset errors on UPDATE_LOADING_STATE?
There was a problem hiding this comment.
The attributes updated related to "loading state" do not cover errors and we want to retain errors while the analysis might still continue. Only on a reset (e.g. when starting a new request) the original default state without errors will be restored.
alvarezmelissa87
approved these changes
Aug 3, 2022
Rebootstrapped and didn't get this anymore. Functionally LGTM 🎉 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2022
- Errors on the application level were not correctly surfaced in the UI. This PR fixes it by combining "transport" stream errors and application errors in a callout above the analysis results table. - This also fixes the problem where a partly populated results table would turn empty again when used with the error prop of EUI's table. We now keep the table on display an show the errors above it in the callout. (cherry picked from commit 70efbf0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2022
…lastic#138115) - Errors on the application level were not correctly surfaced in the UI. This PR fixes it by combining "transport" stream errors and application errors in a callout above the analysis results table. - This also fixes the problem where a partly populated results table would turn empty again when used with the error prop of EUI's table. We now keep the table on display an show the errors above it in the callout. (cherry picked from commit 70efbf0) Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #136265.
errorprop of EUI's table. We now keep the table on display an show the errors above it in the callout.