Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics Monitors Page] Remove custom background styling #137848

Merged
merged 4 commits into from
Aug 23, 2022
Merged

[Synthetics Monitors Page] Remove custom background styling #137848

merged 4 commits into from
Aug 23, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 2, 2022 •
edited
Loading

Summary

Fixes #134690

Remove custom styling for the monitors page !!

image

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 2, 2022
@shahzad31 shahzad31 marked this pull request as ready for review August 2, 2022 15:04
@shahzad31 shahzad31 requested a review from a team as a code owner August 2, 2022 15:04
@shahzad31 shahzad31 removed the v8.4.0 label Aug 2, 2022
@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke
dominiqueclarke approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen Shot 2022-08-18 at 5 53 37 PM

@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 911.9KB 911.6KB -295.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit ec342ca into elastic:main Aug 23, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2022
@dominiqueclarke dominiqueclarke deleted the remove-custom-styling branch August 23, 2022 01:07
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@shahzad31 @kibanamachine @Mpdreamz
remove custom styling (elastic#137848)
d2f9a41 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Synthetics App] Monitors page styles off in dark mode
5 participants
@shahzad31 @dominiqueclarke @elasticmachine @kibana-ci @kibanamachine