[ML] Explain log rate spikes: Mini histogram fixes. #137266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
walterra
added
the
bug
34 tasks
x-pack/plugins/aiops/public/components/spike_analysis_table/spike_analysis_table.tsx
Show resolved
Hide resolved
peteharverson
approved these changes
Jul 27, 2022
qn895
approved these changes
Jul 28, 2022
|
LGTM 🎉 |
|
@elasticmachine merge upstream |
walterra
added
auto-backport
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
that referenced
this pull request
Jul 28, 2022
- Disables tooltips in mini histograms to avoid bug with sticky tooltips and to be in line with APM sparkline behavior. - Fix to set mini histogram background to transparent so the chart background picks up the background of a hovered table row. - Fix some hard coded values by using values provided by EUI. - Fixes an issue where histograms were assigned to the wrong table rows. - Support for loading indicator and empty chart state. - Tweaks analysis table column widths. (cherry picked from commit 3117f67)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2022
- Disables tooltips in mini histograms to avoid bug with sticky tooltips and to be in line with APM sparkline behavior. - Fix to set mini histogram background to transparent so the chart background picks up the background of a hovered table row. - Fix some hard coded values by using values provided by EUI. - Fixes an issue where histograms were assigned to the wrong table rows. - Support for loading indicator and empty chart state. - Tweaks analysis table column widths. (cherry picked from commit 3117f67) Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #136265.
transparentso the chart background picks up the background of a hovered table row.Checklist