-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain log rate spikes: Fix data view title. #137053
Conversation
Pinging @elastic/ml-ui (:ml) |
Much improved to use full width. Index names can be long, so we should plan for this. |
Agree parts of the layout are worth revisiting. For now we keep it in line with Data Visualizer and reuse code from there too. We plan to consolidate some of the components, when we do that we can have a look at the layout too. |
<EuiTitle size={'s'}> | ||
<h2>{dataView.title}</h2> | ||
<h2>{dataView.getName()}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we add an EuiSpacer
underneath?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 2f404a8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only edit I see is add some spacing between the title and components below it. Can be either a spacer or in the scss I imagine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Dima's comment about adding the spacer - LGTM ⚡
Fixed the title spacing. Because this layout variant is part of responsive rules a spacer wasn't suitable because it would break the wider layout's vertical alignment, so added some padding to the title element. Ready for another look @mdefazio. |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Part of #136265.
dataView.getName()
instead ofdataView.title
.scss
brought over from Data Visualizer to improve positioning of long Data View names.Before:
After:
Checklist