Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Log rate spike: support saved search #136765

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Jul 20, 2022

Summary

Adds support for saved searches to logs rate spike UI.

  • ensure search is clearable
  • ensure filters from saved search are applied

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 20, 2022
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner July 20, 2022 19:50
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and local test LGTM.

@alvarezmelissa87
Copy link
Contributor Author

This has been updated to ensure filters from saved search are reflected and search is clearable. Ready for another look when you get a chance 🙏 cc @peteharverson, @walterra

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 349 350 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 463.3KB 464.4KB +1.1KB
ml 3.3MB 3.3MB +41.0B
total +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@walterra
Copy link
Contributor

Test latest changes, clearing the search bar now works for me, great update!

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit c3ac0a1 into elastic:main Jul 22, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 22, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the log-rate-spikes-saved-search branch July 22, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants