Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain log rate spikes: Split main chart by selected field/value pair. #136712

Merged
merged 16 commits into from
Jul 22, 2022
Merged

[ML] Explain log rate spikes: Split main chart by selected field/value pair. #136712

merged 16 commits into from
Jul 22, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 20, 2022 •
edited
Loading

Summary

Part of #136265.

  • Adds the ability to show the hovered/selected field/value pair in the main chart.
  • Optional search queries now get applied to the analysis.

aiops-chart-split-0001

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes ci:deploy-cloud v8.4.0 labels Jul 20, 2022
@walterra walterra self-assigned this Jul 20, 2022
@walterra walterra marked this pull request as ready for review July 20, 2022 12:06
@walterra walterra requested a review from a team as a code owner July 20, 2022 12:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson reviewed Jul 20, 2022
View reviewed changes
x-pack/plugins/aiops/public/components/spike_analysis_table/spike_analysis_table.tsx
// }}
rowProps={(changePoint) => {
return {
onClick: () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking on the currently selected row isn't deselecting the row. There needs to be some way to clear the selection.

Also the selection is retained when the analysis is rerun, but it probably makes sense to clear the selection when changing any of the parameters (time range, brush positions etc).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2f72a3a I added a check to remove any selected or pinned row when the user reruns the analysis. Unselecting a row requires a bit more looking into, I added an item to investigate to the meta issue (#136265).

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

peteharverson
peteharverson approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Can find a way to unpin a selected table row in a follow-up.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 465.0KB 467.0KB +2.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
aiops 17 18 +1

Total ESLint disabled count

id before after diff
aiops 17 18 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit e9d9c69 into elastic:main Jul 22, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 22, 2022
@walterra walterra deleted the ml-aiops-chart-split branch July 22, 2022 14:16
This was referenced Jul 22, 2022
Closed
Merged
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @tylersmalley @kibanamachine