Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain log rate spikes: Fix hooks caching. #136645

Merged
merged 2 commits into from
Jul 19, 2022
Merged

[ML] Explain log rate spikes: Fix hooks caching. #136645

merged 2 commits into from
Jul 19, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 19, 2022 •
edited
Loading

Summary

Part of #136265.

Fixes issues where hooks would return stale data (index pattern, time ranges, total docs etc.).

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 19, 2022
@walterra walterra self-assigned this Jul 19, 2022
@walterra walterra requested a review from a team as a code owner July 19, 2022 14:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Jul 19, 2022
Closed
34 tasks
peteharverson
peteharverson approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can no longer reproduce the issue with incorrect doc counts I was getting on the sample data sets.

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 424.5KB 424.6KB +95.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
aiops 14 13 -1

Total ESLint disabled count

id before after diff
aiops 14 13 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit b264dbc into elastic:main Jul 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 19, 2022
@walterra walterra deleted the ml-aiops-fix-hooks-caching branch July 19, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @kibanamachine