Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time picker should be displayed only if index pattern has time field #13640

Merged
merged 2 commits into from
Aug 29, 2017
Merged

time picker should be displayed only if index pattern has time field #13640

merged 2 commits into from
Aug 29, 2017

Conversation

ppisljar
Copy link
Member

resolves #13354

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review labels Aug 22, 2017
lukasolson
lukasolson requested changes Aug 24, 2017
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like the time picker is always missing in Timelion and TSVB now.

@ppisljar
Copy link
Member Author

@lukasolson thanks! index pattern is not defined for timelion and tsvb ...
also i found another bug where markdown vis did not set showTimePicker to false.

ready for another look

lukasolson
lukasolson approved these changes Aug 28, 2017
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍔

@ppisljar ppisljar merged commit 68fd903 into elastic:master Aug 29, 2017
ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 29, 2017
@ppisljar
time picker should be displayed only if index pattern has time field (e…
ea01ab1 
…lastic#13640)

* time picker should be displayed only if index pattern has time field

* fixing based on review from lukas
ppisljar added a commit to ppisljar/kibana that referenced this pull request Aug 29, 2017
@ppisljar
time picker should be displayed only if index pattern has time field (e…
49ea8d9 
…lastic#13640)

* time picker should be displayed only if index pattern has time field

* fixing based on review from lukas
@ppisljar ppisljar deleted the fix/timePicker branch August 29, 2017 09:22
ppisljar added a commit that referenced this pull request Aug 29, 2017
@ppisljar
time picker should be displayed only if index pattern has time field (#…
f0c6364 
…13640) (#13748)

* time picker should be displayed only if index pattern has time field

* fixing based on review from lukas
ppisljar added a commit that referenced this pull request Aug 29, 2017
@ppisljar
time picker should be displayed only if index pattern has time field (#…
826ca44 
…13640) (#13749)

* time picker should be displayed only if index pattern has time field

* fixing based on review from lukas
@ppisljar ppisljar restored the fix/timePicker branch September 26, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@lukasolson lukasolson lukasolson approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timepicker shows up even when index pattern isn't time-based
3 participants
@ppisljar @lukasolson @thomasneirynck