Kertal discover adhoc dataview #136266

ppisljar · 2022-07-13T10:10:18Z

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…-ref HEAD~1..HEAD --fix'

kibana-ci · 2022-07-18T13:10:29Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #22 / a11y tests using flights sample data Filter panel "before all" hook for "a11y test on add filter panel"
[job] [logs] FTR Configs #22 / a11y tests using flights sample data Filter panel "before all" hook for "a11y test on add filter panel"
[job] [logs] FTR Configs #13 / apps machine learning basic license data visualizer field statistics in Discover when enabled with farequote index pattern displays the 'Field statistics' table content correctly
[job] [logs] FTR Configs #13 / apps machine learning basic license data visualizer field statistics in Discover when enabled with farequote index pattern displays the 'Field statistics' table content correctly
[job] [logs] FTR Configs #10 / context app context accessibility should navigate to the single doc view and give focus to the title h1 on navigate
[job] [logs] FTR Configs #10 / context app context accessibility should navigate to the single doc view and give focus to the title h1 on navigate
[job] [logs] FTR Configs #24 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
[job] [logs] FTR Configs #27 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
[job] [logs] FTR Configs #24 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
[job] [logs] FTR Configs #27 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
[job] [logs] FTR Configs #21 / dashboard app - group 5 old charts library dashboard state "after all" hook for "Saved search will update when the query is changed in the URL"
[job] [logs] FTR Configs #21 / dashboard app - group 5 old charts library dashboard state "after all" hook for "Saved search will update when the query is changed in the URL"
[job] [logs] FTR Configs #21 / dashboard app - group 5 old charts library dashboard state Saved search with no changes will update when the saved object changes
[job] [logs] FTR Configs #21 / dashboard app - group 5 old charts library dashboard state Saved search with no changes will update when the saved object changes
[job] [logs] FTR Configs #21 / dashboard drilldowns Dashboard to URL drilldown should create dashboard to URL drilldown and use it to navigate to discover
[job] [logs] FTR Configs #21 / dashboard drilldowns Dashboard to URL drilldown should create dashboard to URL drilldown and use it to navigate to discover
[job] [logs] FTR Configs #36 / dashboard sample data dashboard "before all" hook for "should launch sample flights data set dashboard"
[job] [logs] FTR Configs #36 / dashboard sample data dashboard "before all" hook for "should launch sample flights data set dashboard"
[job] [logs] FTR Configs #1 / data plugin Session management Discover "before all" hook for "Starts on index pattern select"
[job] [logs] FTR Configs #1 / data plugin Session management Discover "before all" hook for "Starts on index pattern select"
[job] [logs] FTR Configs #41 / Discover alerting Search source Alert should navigate to discover via view in app link
[job] [logs] FTR Configs #41 / Discover alerting Search source Alert should navigate to discover via view in app link
[job] [logs] FTR Configs #15 / discover app discover no data adds a new data view when no data views
[job] [logs] FTR Configs #15 / discover app discover no data adds a new data view when no data views
[job] [logs] FTR Configs #18 / discover app discover tab field data search php should show the correct hit count
[job] [logs] FTR Configs #18 / discover app discover tab field data search php should show the correct hit count
[job] [logs] FTR Configs #43 / Discover discover async search "before all" hook for "search session id should change between searches"
[job] [logs] FTR Configs #43 / Discover discover async search "before all" hook for "search session id should change between searches"
[job] [logs] FTR Configs #30 / discover feature controls discover feature controls security global discover all privileges "before all" hook for "shows discover navlink"
[job] [logs] FTR Configs #30 / discover feature controls discover feature controls security global discover all privileges "before all" hook for "shows discover navlink"
[job] [logs] FTR Configs #32 / home app Kibana browser back navigation should work detect navigate back issues
[job] [logs] FTR Configs #32 / home app Kibana browser back navigation should work detect navigate back issues
[job] [logs] FTR Configs #8 / lens app - group 1 lens query context should carry over time range and pinned filters to discover
[job] [logs] FTR Configs #8 / lens app - group 1 lens query context should carry over time range and pinned filters to discover
[job] [logs] FTR Configs #38 / machine learning - data visualizer field statistics in Discover when enabled with farequote index pattern displays the 'Field statistics' table content correctly
[job] [logs] FTR Configs #38 / machine learning - data visualizer field statistics in Discover when enabled with farequote index pattern displays the 'Field statistics' table content correctly
[job] [logs] FTR Configs #37 / management scripted fields creating and using Painless numeric scripted fields discover scripted field should see scripted field value in Discover
[job] [logs] FTR Configs #37 / management scripted fields creating and using Painless numeric scripted fields discover scripted field should see scripted field value in Discover
[job] [logs] FTR Configs #46 / maps app discover visualize button should link geo_shape fields to Maps application
[job] [logs] FTR Configs #46 / maps app discover visualize button should link geo_shape fields to Maps application
[job] [logs] FTR Configs #16 / Reporting Functional Tests with Deprecated Security configuration enabled Security with reporting_user built-in role Discover: Generate CSV does not allow user that does not have reporting_user role
[job] [logs] FTR Configs #16 / Reporting Functional Tests with Deprecated Security configuration enabled Security with reporting_user built-in role Discover: Generate CSV does not allow user that does not have reporting_user role
[job] [logs] FTR Configs #14 / Reporting Functional Tests with Security enabled Security with reporting_user built-in role Discover: Generate CSV does not allow user that does not have reporting privileges
[job] [logs] FTR Configs #14 / Reporting Functional Tests with Security enabled Security with reporting_user built-in role Discover: Generate CSV does not allow user that does not have reporting privileges
[job] [logs] Jest Tests #4 / Resolve index pattern tests returns fallback data for an invalid index pattern
[job] [logs] FTR Configs #40 / security app dls user East should only see EAST doc
[job] [logs] FTR Configs #40 / security app dls user East should only see EAST doc
[job] [logs] FTR Configs #14 / visualize app visualize lab mode "after all" hook for "disabling does not break loading saved searches"
[job] [logs] FTR Configs #14 / visualize app visualize lab mode "after all" hook for "disabling does not break loading saved searches"
[job] [logs] FTR Configs #14 / visualize app visualize lab mode disabling does not break loading saved searches
[job] [logs] FTR Configs #14 / visualize app visualize lab mode disabling does not break loading saved searches
[job] [logs] FTR Configs #42 / Visualize pre_calculated_histogram appears correctly in discover
[job] [logs] FTR Configs #42 / Visualize pre_calculated_histogram appears correctly in discover

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	492.5KB	492.3KB	-130.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`apm`	14	13	-1
`observability`	6	5	-1
`securitySolution`	74	73	-1
total			-3

ESLint disabled line counts

id	before	after	diff
`apm`	86	83	-3
`enterpriseSearch`	9	7	-2
`observability`	48	47	-1
`synthetics`	61	55	-6
`ux`	10	9	-1
total			-13

Total ESLint disabled count

id	before	after	diff
`apm`	100	96	-4
`enterpriseSearch`	9	7	-2
`observability`	54	52	-2
`securitySolution`	514	513	-1
`synthetics`	67	61	-6
`ux`	13	12	-1
total			-16

History

💔 Build #57316 failed c511ebd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dimaanj · 2022-08-02T13:22:37Z

src/plugins/discover/public/application/main/discover_main_route.tsx

@@ -76,6 +77,8 @@ export function DiscoverMainRoute(props: Props) {
  const loadDefaultOrCurrentIndexPattern = useCallback(
    async (searchSource: ISearchSource) => {
      try {
+        debugger;


I think you have forgotten to remove debugger here. It might be the reason of ci failures.

ppisljar and others added 12 commits June 28, 2022 03:40

data view side panel explore button

0711ffb

reverting discover changes

ddc522e

fix wording and color

d26ade5

fix

ed32da8

Merge branch 'main' into adhocdataviews/sidebar

168e381

Initial implementation

5481613

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

2b7bc0d

…-ref HEAD~1..HEAD --fix'

Fix setting ad-hoc state in URL

e6c4d7d

Merge branch 'main' into discover-adhoc-dataview

4174efc

Merge branch 'main' into discover-adhoc-dataview

ba4ded1

Merge branch 'main' into discover-adhoc-dataview

c586664

cleaning up discover so it doesnt put spec on its state

c511ebd

ppisljar requested review from a team as code owners July 13, 2022 10:10

ppisljar mentioned this pull request Jul 13, 2022

Discover adhoc dataview #135770

Closed

9 tasks

ppisljar and others added 2 commits July 18, 2022 14:54

Merge branch 'main' into kertal-discover-adhoc-dataview

94d6d85

Update data_views.ts

3f2bc57

kertal mentioned this pull request Aug 1, 2022

[Discover] Integration of ad-hoc data views #137671

Closed

dimaanj reviewed Aug 2, 2022

View reviewed changes

ppisljar closed this Aug 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kertal discover adhoc dataview #136266

Kertal discover adhoc dataview #136266

ppisljar commented Jul 13, 2022

kibana-ci commented Jul 18, 2022 •

edited

Loading

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

dimaanj Aug 2, 2022

Kertal discover adhoc dataview #136266

Kertal discover adhoc dataview #136266

Conversation

ppisljar commented Jul 13, 2022

Summary

Checklist

Risk Matrix

For maintainers

kibana-ci commented Jul 18, 2022 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

dimaanj Aug 2, 2022

Choose a reason for hiding this comment

kibana-ci commented Jul 18, 2022 •

edited

Loading