-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain log rate spikes: Use DualBrush component to select WindowParameters for analysis. #136255
Conversation
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: cc @walterra |
<> | ||
{isBrushVisible && ( | ||
<div className="aiopsHistogramBrushes"> | ||
<DualBrush |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for this PR, but could be useful to display the time range of the brush in a tooltip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM overall - aside from Pete's comment and some improvements for follow ups that will be tracked in a separate issue. ⚡
Summary
Part of #136265.
DualBrush
component toDocumentCountChart
to allow the user to selectWindowParameters
for the explain log rate spikes analysis.VIEW_MODE
is for now hard coded tobrush
. In a follow up we will allow a user to switch betweenzoom
mode for navigation andbrush
mode for selection ofWindowParameters
.WindowParameters
has been removed from the wrapping code in the ML plugin.urlState
related code has been moved fromExplainLogRateSpikes
toExplainLogRateSpikesWrapper
.compressed
.Checklist