[Lens] Add the bee #136132
[Lens] Add the bee #136132
Conversation
flash1293
added
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
@elasticmachine merge upstream |
x-pack/plugins/lens/public/editor_frame_service/editor_frame/easteregg/index.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| export function Easteregg(props: { query?: Query }) { |
There was a problem hiding this comment.
This loads the code (even though Lazy), even when the easter-egg query isn't triggered. Consider only loading the easter-egg when the query actually matches.
So I'd break here and return null here on the REGEX-check. And only load the Bee lazily after.
There was a problem hiding this comment.
This is what the code does - the Bees component does nothing but checking the query in a safe way. Only if the amount is larger than one and a bee will be shown, a Bee component is rendered which will lazy-load the bee code (including the image). The Easteregg component is providing the error boundary, so an uncaught exception in the bee/bees component won't be visible in the app.
There was a problem hiding this comment.
oki thx, you're right, I have misunderstood then
|
feature request for even more bees please |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This adds the bee