Closes #13471 - Change split behavior of gauges and metrics vis #13583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:TSVB
|
Jenkins test this |
thomasneirynck
approved these changes
Aug 22, 2017
There was a problem hiding this comment.
nice! works really well.
This is not a bug fix IMHO, more of an enhancement, and I would remove 6.0 label, leaving this as a 6.1 enhancement.
@ppisljar do you want to take second look?
simianhacker
added a commit
that referenced
this pull request
Aug 28, 2017
simianhacker
added a commit
that referenced
this pull request
Aug 28, 2017
shaharmor
reviewed
Sep 12, 2017
| export function visWithSplits(WrappedComponent) { | ||
| function SplitVisComponent(props) { | ||
| const { model, visData } = props; | ||
| if (visData[model.id].series.every(s => s.id.split(':').length === 1)) { |
There was a problem hiding this comment.
@simianhacker I think that this change introduced a bug.
Before this PR, the .series property was being defaulted to [] here, and now its not.
Maybe do something like this:
import { get, last, findIndex, first } from 'lodash';
function SplitVisComponent(props) {
const { model, visData } = props;
const series = get(visData, `${model.id}.series`, []);
// ...and erase all visData[model.id].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #13471 by changing the behavior of gauges and metrics visualizations. Before this PR when you split a series by a terms (or filters) aggregation they would just show up in the primary (and secondary) metric positions for the visualizations. With this PR it will create a gauge for each split.