Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Management] Accessibility - continued #13576

Merged
merged 1 commit into from
Aug 18, 2017
Merged

[Management] Accessibility - continued #13576

merged 1 commit into from
Aug 18, 2017

Conversation

chrisronline
Copy link
Contributor

Fixes #12864

@chrisronline chrisronline requested review from cjcenizal, BigFunger and timroes and removed request for BigFunger August 18, 2017 13:54
timroes
timroes approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cjcenizal
cjcenizal approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisronline chrisronline merged commit e0708ab into elastic:master Aug 18, 2017
chrisronline added a commit that referenced this pull request Aug 18, 2017
@chrisronline
Add aria describes for warning label, #12864 (#13576)
af4d258
chrisronline added a commit that referenced this pull request Aug 18, 2017
@chrisronline
Add aria describes for warning label, #12864 (#13576)
b68b325
@chrisronline
Copy link
Contributor Author

Backport:

6.x: af4d258
6.0: b68b325

@chrisronline chrisronline deleted the management/accessibility_part2 branch August 18, 2017 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@timroes timroes timroes approved these changes

Assignees

@chrisronline chrisronline

@BigFunger BigFunger

Labels
Project:Accessibility review v6.0.0-rc1 v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisronline @timroes @cjcenizal @BigFunger @jimgoodwin