Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Disable/Subdue AIOps sidenav item when not enough permissions. #135658

Merged
merged 1 commit into from
Jul 5, 2022
Merged

[ML] Disable/Subdue AIOps sidenav item when not enough permissions. #135658

merged 1 commit into from
Jul 5, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 4, 2022 •
edited
Loading

Summary

Part of #136265.

Disable/Subdue AIOps sidenav item when not enough permissions.

Before:

image

After:

image

Checklist

@walterra walterra requested a review from a team as a code owner July 4, 2022 16:51
@walterra walterra self-assigned this Jul 4, 2022
@walterra walterra added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 :ml labels Jul 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +11.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

peteharverson
peteharverson approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@walterra walterra merged commit bbafbff into elastic:main Jul 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 5, 2022
@walterra walterra deleted the ml-aiops-fix-sidenav branch July 5, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibana-ci @peteharverson @kibanamachine