Use devicePixelRatio to scale up and down canvas values in TSVB for Tooltip #13565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s values in TSVB
simianhacker
added
bug
simianhacker
added a commit
that referenced
this pull request
Aug 18, 2017
simianhacker
added a commit
that referenced
this pull request
Aug 18, 2017
simianhacker
added a commit
that referenced
this pull request
Aug 18, 2017
|
Back ported to 5.6 with 042e502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12866 by using devicePixelRatio to scale up the point when deciding to change the tooltip direction. It also scales down the canvas size when determining the right value for the tooltip when it switches direction. To verify this actually fixes the issue you must test this on a Mac with a Retina display. First open TSVB with any "Time Series chart" in Chrome on the retina display. Then move the tooltip to the right edge of the chart (it should cut off the tooltip). Now checkout this PR and reload the same page (on the retina display).
Before
After