-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting stack-monitoring PoC #135365
Alerting stack-monitoring PoC #135365
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
This PR is a follow up from #123726 |
I recall that @gmmorris commented about whether it's useful displaying Overdue Rules to the user. Do we want to remove this: |
Good catch, @neptunian. We'll want to change the text for that label to match the rename elsewhere. |
@@ -36,6 +37,7 @@ export default function ({ getService }) { | |||
.set('kbn-xsrf', 'xxx') | |||
.send({ timeRange }) | |||
.expect(200); | |||
body.metrics = normalizeDataTypeDifferences(body.metrics, fixture); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XavierM I'm thinking those values you were getting were actually correct and we need to update the fixtures with those values instead of normalizing. Since we aren't using a derivative unit for these metrics we wouldn't expect the normalized response? And we'd expect these values in the fixture to change now to the non normalized values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I'm in there fixing the tests after I added the technical preview badge, I'll take care of this also.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Thanks for all of your help on this, @neptunian. |
Thanks @neptunian you're a star |
Update title and description like this beautiful option I