Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting stack-monitoring PoC #135365

Merged
merged 15 commits into from
Jul 22, 2022
Merged

Alerting stack-monitoring PoC #135365

merged 15 commits into from
Jul 22, 2022

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Jun 28, 2022

Update title and description like this beautiful option I

image

@XavierM XavierM marked this pull request as ready for review July 20, 2022 21:13
@XavierM XavierM requested a review from a team as a code owner July 20, 2022 21:13
@XavierM XavierM added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:feature Makes this part of the condensed release notes v8.4.0 labels Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM XavierM requested review from XavierM and neptunian and removed request for XavierM July 20, 2022 21:17
@neptunian
Copy link
Contributor

This PR is a follow up from #123726

@neptunian
Copy link
Contributor

neptunian commented Jul 21, 2022

I recall that @gmmorris commented about whether it's useful displaying Overdue Rules to the user. Do we want to remove this:
Screen Shot 2022-07-21 at 1 07 45 PM

@kobelb
Copy link
Contributor Author

kobelb commented Jul 21, 2022

Good catch, @neptunian. We'll want to change the text for that label to match the rename elsewhere.

@kobelb
Copy link
Contributor Author

kobelb commented Jul 21, 2022

5f1d9ba updates the overview card to no longer use the "Overdue" phrasing:
Screen Shot 2022-07-21 at 11 39 28 AM

And 07a945b adds technical preview badges:

Screen Shot 2022-07-21 at 11 40 57 AM

@@ -36,6 +37,7 @@ export default function ({ getService }) {
.set('kbn-xsrf', 'xxx')
.send({ timeRange })
.expect(200);
body.metrics = normalizeDataTypeDifferences(body.metrics, fixture);
Copy link
Contributor

@neptunian neptunian Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierM I'm thinking those values you were getting were actually correct and we need to update the fixtures with those values instead of normalizing. Since we aren't using a derivative unit for these metrics we wouldn't expect the normalized response? And we'd expect these values in the fixture to change now to the non normalized values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'm in there fixing the tests after I added the technical preview badge, I'll take care of this also.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 504 505 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 479.2KB 479.6KB +346.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb
Copy link
Contributor Author

kobelb commented Jul 21, 2022

Thanks for all of your help on this, @neptunian.

@gmmorris
Copy link
Contributor

Thanks @neptunian you're a star

@XavierM XavierM merged commit c0ad0f9 into elastic:main Jul 22, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 22, 2022
@gmmorris gmmorris added the Feature:Alerting/RulesManagement Issues related to the Rules Management UX label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:feature Makes this part of the condensed release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants