Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain log rate spikes: Add DualBrush component. #135318

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jun 28, 2022

Summary

Part of #136265.

Adds the code for the dual brush component for users to be able select log rate spikes in histogram charts.

For this PR a new package @kbn/aiops-components was created that also includes ProgressControls from @kbn/aiops-utils now. The reason for this is: The brush component includes code from d3 that cannot be imported on the server side which aiops-utils was also used for.

Note: This PR just adds the component to @kbn/aiops-components that we bring over from the PoC, it's not used yet in the UI, this will be done in follow-ups.

Checklist

@walterra walterra self-assigned this Jun 28, 2022
@walterra walterra marked this pull request as ready for review June 28, 2022 18:00
@walterra walterra requested review from a team as code owners June 28, 2022 18:00
@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 100 248 +148
apm 1298 1299 +1
ml 1665 1664 -1
total +148

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/aiops-components - 6 +6
@kbn/aiops-utils 26 24 -2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 277.4KB 380.1KB +102.7KB
apm 2.9MB 3.0MB +9.9KB
ml 3.4MB 3.4MB -2.0B
total +112.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiops 3.7KB 3.7KB +57.0B
Unknown metric groups

API count

id before after diff
@kbn/aiops-components - 6 +6
@kbn/aiops-utils 48 46 -2
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 0490793 into elastic:main Jul 6, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 6, 2022
@walterra walterra deleted the ml-aiops-brush-component branch July 6, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants