[Metrics UI] Rename "Metrics" to "Infrastructure" in appropriate places #135278
Conversation
…to "Infrastructure"
matschaffer
added
Feature:Metrics UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
x-pack/test/functional/apps/infra/feature_controls/infrastructure_security.ts
Outdated
Show resolved
Hide resolved
| @@ -169,7 +169,7 @@ export class Plugin implements InfraClientPluginClass { | |||
| core.application.register({ | |||
| id: 'metrics', | |||
There was a problem hiding this comment.
This change is just for the labels, isn't it? I'm wondering if the application register should have the id replaced too
There was a problem hiding this comment.
I’m thinking not at this point. Similar to how I’d like to leave the urls as-is. Especially with the growing interactions with apm UI it seems best to keep this change in the view layer.
…ure_security.ts Co-authored-by: Carlos Crespo <[email protected]>
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @matschaffer |
|
Looks like we missed updating the breadcrumb label?
I imagine there's redirect options in Kibana even for significant route changes like this? Do we need a follow-up issue? |
|
Nice catch. I put a reminder for myself to open a follow up issue on Monday. |
|
Opened #136076 |
Summary
Just renaming a few links.
The issue also mentions possibly updating the
/app/metricsURL to/app/infrastructure. I propose we leave this as-is to avoid the complication, especially considering cross linking with APM.Fixes #123972