fix available metric aggs #13518
Merged
fix available metric aggs #13518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
Feature:Visualizations
|
@thomasneirynck looks good for the most part, all aggregations seem to be there. There is some odd behavior when looking at Standard Deviation with the Arc visualization though. It looks to me like it's only applying the Arc to one of the bounds vs. both of them. Otherwise, it applies the circle viz.
Also as we discussed earlier, we'll need to get rid of the Geo Bounding aggregation at some point. |
|
^ that seems to be a bug. any chance you can create an issue for this? |
alexfrancoeur
approved these changes
Aug 17, 2017
There was a problem hiding this comment.
LGTM, opened #13562 to track the odd arc visualizations with standard deviation
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13267.
Unlike #13330, we are not refactoring how we reference these dependencies. That will be a separate effort.
This also does not fix #13517, which cannot be backported to v5.