Improve Dev Tools accessibility

src/core_plugins/console/public/index.html

@@ -5,6 +5,7 @@
       <div id="editor_actions">
         <kbn-tooltip text="click to send request">
           <a
+            kbn-accessible-click
             class="editor_action"
             ng-click="sendSelected()"
             data-test-subj="send-request-button">
@@ -27,10 +28,10 @@
             aria-labelledby="consoleRequestOptions"
           >
             <li role="menuitem">
-              <a class="link" id="copy_as_curl">Copy as cURL</a>
+              <button class="link" id="copy_as_curl">Copy as cURL</button>
             </li>
             <li role="menuitem">
-              <a ng-click="autoIndent($event)">Auto indent</a>
+              <button ng-click="autoIndent($event)">Auto indent</button>
             </li>
           </ul>
         </span>

src/core_plugins/console/public/src/controllers/sense_controller.js

@@ -16,7 +16,7 @@ module.run(function (Private, $rootScope) {
   };
 });
 
-module.controller('SenseController', function SenseController(Private, $scope, $timeout, $location, docTitle) {
+module.controller('SenseController', function SenseController(Private, $scope, $timeout, $location, docTitle, kbnUiAceKeyboardModeService) {
   docTitle.change('Console');
 
   $scope.topNavController = Private(SenseTopNavController);
@@ -28,6 +28,7 @@ module.controller('SenseController', function SenseController(Private, $scope, $
     output = initializeOutput($('#output'));
     input = initializeInput($('#editor'), $('#editor_actions'), $('#copy_as_curl'), output);
     init(input, output, $location.search().load_from);
+    kbnUiAceKeyboardModeService.initialize($scope, $('#editor'));
   });
 
   $scope.sendSelected = () => {

src/ui/public/accessibility/__tests__/kbn_ui_ace_keyboard_mode.js

@@ -55,3 +55,53 @@ describe('kbnUiAceKeyboardMode directive', () => {
   });
 
 });
+
+describe('kbnUiAceKeyboardModeService', () => {
+  let element;
+
+  beforeEach(ngMock.module('kibana'));
+
+  beforeEach(ngMock.inject(($compile, $rootScope, kbnUiAceKeyboardModeService) => {
+    const scope = $rootScope.$new();
+    element = $compile(`<div ui-ace></div>`)(scope);
+    kbnUiAceKeyboardModeService.initialize(scope, element);
+  }));
+
+  it('should add the hint element', () => {
+    expect(element.find('.uiAceKeyboardHint').length).to.be(1);
+  });
+
+  describe('hint element', () => {
+    it('should be tabable', () => {
+      expect(element.find('.uiAceKeyboardHint').attr('tabindex')).to.be('0');
+    });
+
+    it('should move focus to textbox and be inactive if pressed enter on it', () => {
+      const textarea = element.find('textarea');
+      sinon.spy(textarea[0], 'focus');
+      const ev = angular.element.Event('keydown'); // eslint-disable-line new-cap
+      ev.keyCode = ENTER_KEY;
+      element.find('.uiAceKeyboardHint').trigger(ev);
+      expect(textarea[0].focus.called).to.be(true);
+      expect(element.find('.uiAceKeyboardHint').hasClass('uiAceKeyboardHint-isInactive')).to.be(true);
+    });
+
+    it('should be shown again, when pressing Escape in ace editor', () => {
+      const textarea = element.find('textarea');
+      const hint = element.find('.uiAceKeyboardHint');
+      sinon.spy(hint[0], 'focus');
+      const ev = angular.element.Event('keydown'); // eslint-disable-line new-cap
+      ev.keyCode = ESC_KEY_CODE;
+      textarea.trigger(ev);
+      expect(hint[0].focus.called).to.be(true);
+      expect(hint.hasClass('uiAceKeyboardHint-isInactive')).to.be(false);
+    });
+  });
+
+  describe('ui-ace textarea', () => {
+    it('should not be tabable anymore', () => {
+      expect(element.find('textarea').attr('tabindex')).to.be('-1');
+    });
+  });
+
+});

src/ui/public/accessibility/kbn_ui_ace_keyboard_mode.js

@@ -19,9 +19,9 @@ import { ESC_KEY_CODE, ENTER_KEY } from 'ui_framework/services';
 
 let aceKeyboardModeId = 0;
 
-uiModules.get('kibana').directive('kbnUiAceKeyboardMode', () => ({
-  restrict: 'A',
-  link(scope, element) {
+uiModules.get('kibana')
+.factory('kbnUiAceKeyboardModeService', () => ({
+  initialize(scope, element) {
     const uniqueId = `uiAceKeyboardHint-${scope.$id}-${aceKeyboardModeId++}`;
 
     const hint = angular.element(
@@ -77,4 +77,10 @@ uiModules.get('kibana').directive('kbnUiAceKeyboardMode', () => ({
     uiAceTextbox.attr('tabindex', '-1');
     element.prepend(hint);
   }
+}))
+.directive('kbnUiAceKeyboardMode', (kbnUiAceKeyboardModeService) => ({
+  restrict: 'A',
+  link(scope, element) {
+    kbnUiAceKeyboardModeService.initialize(scope, element);
+  }
 }));

src/ui/public/styles/bootstrap/dropdowns.less

@@ -62,7 +62,8 @@
   }
 
   // Links within the dropdown menu
-  > li > a {
+  > li > a,
+  > li > button {
     display: block;
     padding: 3px 20px;
     clear: both;
@@ -71,10 +72,19 @@
     color: @dropdown-link-color;
     white-space: nowrap; // prevent links from randomly breaking onto new lines
   }
+
+  > li > button {
+    appearance: none;
+    background: none;
+    border: none;
+    width: 100%;
+    text-align: left;
+  }
 }
 
 // Hover/Focus state
-.dropdown-menu > li > a {
+.dropdown-menu > li > a,
+.dropdown-menu > li > button {
   &:hover,
   &:focus {
     text-decoration: none;
@@ -84,6 +94,7 @@
 }
 
 // Active state
+.dropdown-menu > .active > button,
 .dropdown-menu > .active > a {
   &,
   &:hover,