[Discover] Fix legacy sort parameter provided by URL #134447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cloud_security_posture plugin (elastic#130630)
…-ref HEAD~1..HEAD --fix'
kertal
added
the
Team:DataDiscovery
|
@elasticmachine merge upstream |
kertal
commented
Jun 20, 2022
src/plugins/discover/public/application/main/services/discover_state.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
changed the title
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
kertal
changed the title
kibanamachine
added
v8.4.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We switched to multisort a long time ago in #41918. Before this change users could just provide one sort parameter. This PR handles the case correctly when there's a
legacysort parameter incoming by the URL. It was broken for a long time, but was not noticed, since it was not possible tounsortthe classic table. With the change to classic table, q legacy sort parameter caused the table to be unsorted. This PR takes care of that, by migrating the legacy sort to multisort if needed.Here's a testable link (containing
sort:!(timestamp,desc))as sort param, which is legacy.🥣 Deployment with fix
To compare it you can test with an installation where it doesn't work
🥣 Deployment without fix
it's not sorted:
Fixes #132892
Checklist