Make 'all filters' actions keyboard accessible #13391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
approved these changes
Aug 8, 2017
|
jenkins, test this |
aphelionz
approved these changes
Aug 9, 2017
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 9, 2017
* Make 'all filters' actions keyboard accessible * Add extra aria props to actions toggle
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 9, 2017
* Make 'all filters' actions keyboard accessible * Add extra aria props to actions toggle
Bargs
added a commit
that referenced
this pull request
Aug 9, 2017
Bargs
added a commit
that referenced
this pull request
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12640
"Actions" toggle and all of the actions links can now be accessed via the keyboard. I also added
aria-expandedandaria-controlsto the toggle link.