-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML ]API integration tests for max_anomaly_score
endpoint
#133776
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/test/api_integration/apis/ml/results/max_anomaly_score.ts
Outdated
Show resolved
Hide resolved
…o ml-130648-max-anomaly-score
x-pack/test/api_integration/apis/ml/results/max_anomaly_score.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question about the suite name (I'll be out tomorrow, so feel free to merge with or without changing the suite name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but otherwise LGTM
ml.api.assertResponseStatusCode(200, status, body); | ||
expect(body.maxScore).to.be.above(50); | ||
}); | ||
it('should response with an error when job with provided id does not exist', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - should respond with an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in e7f4d95
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @darnautov |
* max_anomaly_score tests * 404 test * remove tag * fix group name and a typo (cherry picked from commit 3902b17)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#133820) * max_anomaly_score tests * 404 test * remove tag * fix group name and a typo (cherry picked from commit 3902b17) Co-authored-by: Dima Arnautov <[email protected]>
Summary
Part of #130648
API integration tests for the
max_anomaly_score
endpoint.Checklist