Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fixes action parameter names in Index connector docs #133725

Merged
merged 3 commits into from
Jun 8, 2022
Merged

[DOCS] Fixes action parameter names in Index connector docs #133725

merged 3 commits into from
Jun 8, 2022

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jun 7, 2022 •
edited
Loading

Summary

This PR:

  • fixes the action parameter names in an example of the Index connector docs,
  • changes a screenshot to contain the proper parameter names,
  • introduces line breaks on the page.

Preview

Index connector docs

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

@szabosteve szabosteve added Team:Docs release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v8.0.2 v8.1.4 v8.2.2 v8.4.0 v7.17.5 v8.3.1 labels Jun 7, 2022
@szabosteve szabosteve requested review from EricDavisX and ymao1 June 7, 2022 09:52
@szabosteve szabosteve marked this pull request as ready for review June 7, 2022 10:27
@szabosteve szabosteve requested review from a team as code owners June 7, 2022 10:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lcawl
lcawl approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@szabosteve szabosteve merged commit a8cef96 into elastic:main Jun 8, 2022
@szabosteve szabosteve deleted the fix.index.connector branch June 8, 2022 10:15
@szabosteve szabosteve added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 8, 2022
@szabosteve szabosteve mentioned this pull request Jun 8, 2022
Merged
szabosteve added a commit to szabosteve/kibana that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (elastic#133725)
d87c3ec
kibanamachine pushed a commit that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725)
a7c0694 
(cherry picked from commit a8cef96)
@kibanamachine kibanamachine mentioned this pull request Jun 8, 2022
Merged
szabosteve added a commit to szabosteve/kibana that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (elastic#133725)
81f4573
@szabosteve szabosteve mentioned this pull request Jun 8, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725)
3e4c500 
(cherry picked from commit a8cef96)
@kibanamachine kibanamachine mentioned this pull request Jun 8, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725)
81108e1 
(cherry picked from commit a8cef96)
@kibanamachine kibanamachine mentioned this pull request Jun 8, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.0 Backport failed because of merge conflicts
✅ 8.1
✅ 8.2
❌ 7.17 Backport failed because of merge conflicts
✅ 8.3

Manual backport

To create the backport manually run:

node scripts/backport --pr 133725

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@szabosteve szabosteve mentioned this pull request Jun 8, 2022
Merged
szabosteve added a commit to szabosteve/kibana that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (elastic#133725)
6a909cd
This was referenced Jun 8, 2022
Merged
Merged
szabosteve added a commit that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725) (#133885)
ab3a018
kibanamachine added a commit that referenced this pull request Jun 8, 2022
@kibanamachine @szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725) (#133888)
b6ed351 
(cherry picked from commit a8cef96)

Co-authored-by: István Zoltán Szabó <[email protected]>
kibanamachine added a commit that referenced this pull request Jun 8, 2022
@kibanamachine @szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725) (#133886)
baf9a6f 
(cherry picked from commit a8cef96)

Co-authored-by: István Zoltán Szabó <[email protected]>
kibanamachine added a commit that referenced this pull request Jun 8, 2022
@kibanamachine @szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725) (#133889)
27f5777 
(cherry picked from commit a8cef96)

Co-authored-by: István Zoltán Szabó <[email protected]>
szabosteve added a commit that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725) (#133890)
f2a66f1
szabosteve added a commit that referenced this pull request Jun 8, 2022
@szabosteve
[8.0] [DOCS] Fixes variable names in Index connector docs. (#133725) (#…
3cb9acd 
…133892)

* Resolves conflict.

* Apply suggestions from code review
szabosteve added a commit that referenced this pull request Jun 8, 2022
@szabosteve
[DOCS] Fixes variable names in Index connector docs. (#133725) (#133887)
6bb5bdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

@ymao1 ymao1 ymao1 approved these changes

@EricDavisX EricDavisX Awaiting requested review from EricDavisX

Assignees
No one assigned
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.17.5 v8.0.2 v8.1.4 v8.2.2 v8.3.1 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @elasticmachine @kibanamachine @ymao1 @lcawl