Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Dashboards section title in the old nav #133719

Merged
merged 3 commits into from
Jun 7, 2022
Merged

[SecuritySolution] Dashboards section title in the old nav #133719

merged 3 commits into from
Jun 7, 2022

Conversation

semd
Copy link
Contributor

@semd semd commented Jun 7, 2022 •
edited
Loading

Summary

New section title added to the old side navigation, grouping the "Dashboards" links.
issue: #133656

dashboards

@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.4.0 labels Jun 7, 2022
@semd semd requested a review from a team as a code owner June 7, 2022 09:35
@semd semd self-assigned this Jun 7, 2022
@semd semd requested a review from a team as a code owner June 7, 2022 09:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

machadoum
machadoum approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.1MB 5.1MB +107.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd added v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 7, 2022
@semd semd merged commit eed6df7 into elastic:main Jun 7, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.3:
- [Security Solution][Detection & Response] Create the new page with basic parts (#127960)

Manual backport

To create the backport manually run:

node scripts/backport --pr 133719

Questions ?

Please refer to the Backport tool documentation

semd added a commit to semd/kibana that referenced this pull request Jun 7, 2022
@semd
[SecuritySolution] Dashboards section title in the old nav (elastic#1…
ca8e3f8 
…33719)

* add dashboards section title to old nav

* test fixed

* snapshot rollback

(cherry picked from commit eed6df7)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/navigation/use_security_solution_navigation/index.test.tsx
@semd semd mentioned this pull request Jun 7, 2022
Merged
semd added a commit that referenced this pull request Jun 7, 2022
@semd
[SecuritySolution] Dashboards section title in the old nav (#133719) (#…
2c94a87 
…133814)

* add dashboards section title to old nav

* test fixed

* snapshot rollback

(cherry picked from commit eed6df7)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/navigation/use_security_solution_navigation/index.test.tsx
@nastasha-solomon nastasha-solomon mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

Assignees

@semd semd

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@semd @elasticmachine @kibana-ci @kibanamachine @machadoum