Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix ML sync API example #133585

Merged
merged 3 commits into from
Jun 8, 2022
Merged

[DOCS] Fix ML sync API example #133585

merged 3 commits into from
Jun 8, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 3, 2022

Summary

There is an extra curly bracket in the example for https://www.elastic.co/guide/en/kibana/master/machine-learning-api-sync.html

This PR also adds the example in the open API specification.

Preview

https://kibana_133585.docs-preview.app.elstc.co/guide/en/kibana/master/machine-learning-api-sync.html

@lcawl lcawl added Team:Docs :ml release_note:skip Skip the PR/issue when compiling release notes docs auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.3.1 labels Jun 3, 2022
@lcawl lcawl requested a review from szabosteve June 6, 2022 15:11
@lcawl lcawl marked this pull request as ready for review June 6, 2022 15:11
@lcawl lcawl requested a review from a team as a code owner June 6, 2022 15:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition and fix! LGTM.

@lcawl lcawl merged commit b7ae8a2 into elastic:main Jun 8, 2022
@lcawl lcawl deleted the ml-sync branch June 8, 2022 14:27
kibanamachine pushed a commit that referenced this pull request Jun 8, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 14, 2022
kibanamachine added a commit that referenced this pull request Jun 14, 2022
(cherry picked from commit b7ae8a2)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs :ml release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.3.1 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants