Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fixed tooltips for text and keyword fields displaying 'Unknown field' in expanded document #133536

Merged
merged 8 commits into from
Jun 10, 2022
Merged

[Discover] Fixed tooltips for text and keyword fields displaying 'Unknown field' in expanded document #133536

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
723b332
[Discover] Fixed tooltips for text and keyword fields displaying 'Unk…
davismcphee Jun 3, 2022
8a7b14a
Merge branch 'main' into fix-text-keyword-field-tooltips
kibanamachine Jun 7, 2022
97607b4
Merge branch 'main' into fix-text-keyword-field-tooltips
davismcphee Jun 8, 2022
b76c361
[Discover] Added tests for getFieldTypeName function
davismcphee Jun 8, 2022
594cf5e
Merge branch 'main' into fix-text-keyword-field-tooltips
davismcphee Jun 8, 2022
637709d
Merge branch 'main' into fix-text-keyword-field-tooltips
davismcphee Jun 9, 2022
f816c4d
[Discover] Fixing issue where i18n defaultMessage was a variable inst…
davismcphee Jun 9, 2022
6e89976
Merge branch 'main' into fix-text-keyword-field-tooltips
davismcphee Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/discover/public/application/main/components/sidebar/discover_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import type { DataViewField, DataView } from '@kbn/data-views-plugin/public';
import { getTypeForFieldIcon } from '../../../../utils/get_type_for_field_icon';
import { DiscoverFieldDetails } from './discover_field_details';
import { FieldDetails } from './types';
import { getFieldTypeName } from './lib/get_field_type_name';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for cleaning this up and removing duplicated code 👍 . You can flag the PR ready for review. One thing you could add on top of it, could be a Jest test for e.g. discover_field.tsx that would catch the error. Or a basic one for get_field_type_name.ts

Copy link
Contributor Author

@davismcphee davismcphee Jun 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added for get_field_type_name.ts

import { getFieldTypeName } from '../../../../utils/get_field_type_name';
import { DiscoverFieldVisualize } from './discover_field_visualize';

function wrapOnDot(str?: string) {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/discover/public/components/field_name/field_name.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { i18n } from '@kbn/i18n';
import { FieldIcon, FieldIconProps } from '@kbn/react-field';
import { getFieldSubtypeMulti } from '@kbn/data-views-plugin/public';
import type { DataViewField } from '@kbn/data-views-plugin/public';
import { getFieldTypeName } from './field_type_name';
import { getFieldTypeName } from '../../utils/get_field_type_name';

interface Props {
fieldName: string;
Expand Down
63 changes: 0 additions & 63 deletions src/plugins/discover/public/components/field_name/field_type_name.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...onents/sidebar/lib/get_field_type_name.ts → ...cover/public/utils/get_field_type_name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import { i18n } from '@kbn/i18n';

export function getFieldTypeName(type: string) {
export function getFieldTypeName(type?: string) {
switch (type) {
case 'boolean':
return i18n.translate('discover.fieldNameIcons.booleanAriaLabel', {
Expand Down