Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Observability] Remove core and plugins from PluginContext #133466

Merged
merged 5 commits into from
Jun 8, 2022
Merged

[Unified Observability] Remove core and plugins from PluginContext #133466

merged 5 commits into from
Jun 8, 2022

Conversation

estermv
Copy link
Contributor

@estermv estermv commented Jun 3, 2022

Summary

Closes #132694

Remove core and plugins from the PluginContext and pass the appropriate dependencies to getExploratoryViewEmbeddable

@estermv estermv added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Unified observability v8.3.0 labels Jun 3, 2022
@estermv
Copy link
Contributor Author

estermv commented Jun 3, 2022

@elasticmachine merge upstream

@estermv estermv marked this pull request as ready for review June 3, 2022 11:23
@estermv estermv requested review from a team as code owners June 3, 2022 11:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@estermv estermv requested a review from shahzad31 June 3, 2022 11:24
@estermv
Copy link
Contributor Author

estermv commented Jun 8, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 495.8KB 495.8KB +13.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 63.1KB 63.1KB +41.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@estermv estermv added v8.4.0 and removed v8.3.0 labels Jun 8, 2022
@estermv estermv merged commit bb3d525 into elastic:main Jun 8, 2022
@estermv estermv deleted the 132694-plugin-context-cleaning branch June 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Unified observability v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unified Observability] Remove core and plugins from PluginContext
6 participants
@estermv @elasticmachine @kibana-ci @jasonrhodes @shahzad31 @kibanamachine