Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] fix edit tags list displaying old values after edit #133465

Merged
merged 2 commits into from
Jun 3, 2022
Merged

[Cases] fix edit tags list displaying old values after edit #133465

merged 2 commits into from
Jun 3, 2022

Conversation

academo
Copy link
Contributor

@academo academo commented Jun 3, 2022 •
edited
Loading

Summary

After #130544 was merged the tag list form started showing this behaviour due to the way the form was implemented.

Fixes #133464

@academo academo added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 labels Jun 3, 2022
@academo academo requested a review from cnasikas June 3, 2022 08:04
@academo academo self-assigned this Jun 3, 2022
@academo academo requested a review from a team as a code owner June 3, 2022 08:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@academo academo enabled auto-merge (squash) June 3, 2022 08:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 357.4KB 357.4KB +26.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 74 75 +1

Total ESLint disabled count

id before after diff
cases 90 91 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

@academo academo merged commit 399fca1 into elastic:main Jun 3, 2022
kibanamachine pushed a commit that referenced this pull request Jun 3, 2022
@academo
fix edit tags list displaying old values after edit (#133465)
2795c4b 
(cherry picked from commit 399fca1)
@kibanamachine kibanamachine mentioned this pull request Jun 3, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 3, 2022
@kibanamachine @academo
fix edit tags list displaying old values after edit (#133465) (#133490)
ce7c630 
(cherry picked from commit 399fca1)

Co-authored-by: Esteban Beltran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@academo academo

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] old tag list state remains after editing tags.
5 participants
@academo @elasticmachine @kibana-ci @kibanamachine @cnasikas