Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB2Lens] Use pick_max instead of clamp for positive only #133460

Merged
merged 1 commit into from
Jun 3, 2022
Merged

[TSVB2Lens] Use pick_max instead of clamp for positive only #133460

merged 1 commit into from
Jun 3, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 3, 2022 •
edited
Loading

Summary

For the transition from TSVB positive_only function to Lens formula we are using clamp. This PR uses pick_max instead as I think it is a better choice and makes the code a bit cleaner.

tsvb2lens

Checklist

@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Lens v8.4.0 release_note:enhancement backport:skip This commit does not require backporting labels Jun 3, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 466.4KB 466.3KB -114.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 3, 2022
@stratoula
Copy link
Contributor Author

stratoula commented Jun 3, 2022 •
edited
Loading

ℹ️ I added this as an enhancement as clamp for positive_only is already released so we might want to inform the users. Feel free to change the label to skip if you dont agree. I have no strong opinion!

@stratoula stratoula marked this pull request as ready for review June 3, 2022 08:13
@stratoula stratoula requested a review from a team as a code owner June 3, 2022 08:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit cf02fe8 into elastic:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stratoula @kibana-ci @elasticmachine @dej611