Fix dark theme issues with spy toggle and spy pane #13345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
Feature:Dashboard
snide
suggested changes
Aug 5, 2017
There was a problem hiding this comment.
My guess, looking at this .less file is that @cjcenizal would probably prefer you do this in the ui_framework itself over here...
https://github.com/elastic/kibana/blob/master/ui_framework/components/icon/_icon.scss
You can use the @include darkTheme mixin to apply the value. You can see a similar application in the button.scss file.
snide
reviewed
Aug 5, 2017
src/ui/public/styles/dark-theme.less
Outdated
| @@ -254,6 +254,14 @@ | |||
| // /src/ui/public/visualize/visualize.less | |||
| .visualize-show-spy { | |||
| border-top-color: @visualize-show-spy-border; | |||
|
|
|||
| .kuiIcon { | |||
There was a problem hiding this comment.
Ah, good point, and done!
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 8, 2017
* Fix dark theme issues with spy toggle and spy pane * Port dark theme portion of styling kuiIcon into uiFramework library
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 8, 2017
* Fix dark theme issues with spy toggle and spy pane * Port dark theme portion of styling kuiIcon into uiFramework library
This was referenced Aug 8, 2017
stacey-gammon
added a commit
that referenced
this pull request
Aug 9, 2017
stacey-gammon
added a commit
that referenced
this pull request
Aug 9, 2017
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Oct 12, 2017
* Fix dark theme issues with spy toggle and spy pane * Port dark theme portion of styling kuiIcon into uiFramework library
This was referenced Oct 12, 2017
stacey-gammon
added a commit
that referenced
this pull request
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13325 and #12181
Before:
After:
