Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.4] [Security Solution] [Kubernetes Security] Move kubernetes link to dashboard in new security nav #133411

Merged
merged 5 commits into from
Jun 8, 2022
Merged

[8.4] [Security Solution] [Kubernetes Security] Move kubernetes link to dashboard in new security nav #133411

merged 5 commits into from
Jun 8, 2022

Conversation

zizhouW
Copy link
Contributor

@zizhouW zizhouW commented Jun 2, 2022 •
edited
Loading

Move kubernetes link (feature flagged currently kubernetesEnabled) from Security -> Explore to Security -> Dashboard #131858 (comment)
image

Awaiting description and image for the link from product
Added description and image from product

@zizhouW zizhouW added release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.4.0 backport:skip This commit does not require backporting labels Jun 2, 2022
@zizhouW zizhouW self-assigned this Jun 2, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3020 3021 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.1MB 5.1MB +309.0B
Unknown metric groups

miscellaneous assets size

id before after diff
securitySolution 3.3MB 3.4MB +87.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @zizhouW

@zizhouW zizhouW marked this pull request as ready for review June 7, 2022 20:26
@zizhouW zizhouW requested a review from a team June 7, 2022 20:26
@zizhouW zizhouW requested a review from a team as a code owner June 7, 2022 20:26
opauloh
opauloh approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

semd
semd approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM!

@zizhouW zizhouW merged commit e48db81 into elastic:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opauloh opauloh opauloh approved these changes

@semd semd semd approved these changes

Assignees

@zizhouW zizhouW

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zizhouW @kibana-ci @semd @opauloh