Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build info from management section to status page #13341

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Aug 4, 2017

As discussed in #11526 we removed the build info and its icon from the management screen, and as @uboness suggested move it to the status page.

Fixes #11526 and fixes #8225

@timroes timroes requested review from tsullivan and cjcenizal August 4, 2017 13:52
@jbudz
Copy link
Member

jbudz commented Aug 4, 2017

Also closes #8225

@tylersmalley
Copy link
Contributor

I believe this was the only reason the info attribute existed on the management section, so we could clean that up as well. It's referenced in the sections.js and the landing page.

@timroes
Copy link
Contributor Author

timroes commented Aug 7, 2017

@tylersmalley I've removed it from the section.js. Haven't found it anywhere in the landing page (where it wasn't already removed by the PR beforehand). Are there still some occurrences I've still missed?

@timroes
Copy link
Contributor Author

timroes commented Aug 7, 2017

Jenkins, test this.

@tsullivan
Copy link
Member

It is a huge improvement to see the build info right there when the status is Red!

image

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure if there is anything that needs to be removed from landing.html, but it doesn't look like it to me.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tylersmalley
Copy link
Contributor

@timroes, it's in the template here and here. The CSS styles can also be removed.

@timroes
Copy link
Contributor Author

timroes commented Aug 8, 2017

@tylersmalley I am confused, I already removed these with my first commit here and here. I guess we kind of talked past each other here :-) I will merge this, and if there are still things left over, I would create another PR for it.

@timroes timroes merged commit d71bea6 into elastic:master Aug 8, 2017
@timroes timroes deleted the build-info branch August 8, 2017 10:13
@timroes timroes changed the title Move build-info to status page Move build info from management section to status page Aug 8, 2017
@timroes timroes added the v6.1.0 label Aug 8, 2017
timroes added a commit that referenced this pull request Aug 8, 2017
* Move build-info to status page
* Remove info property from management section
timroes added a commit that referenced this pull request Aug 8, 2017
* Move build-info to status page
* Remove info property from management section
@timroes
Copy link
Contributor Author

timroes commented Aug 8, 2017

Backports:

6.0: c2b3c3c
6.x: ea2a31d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Info button on Management page Remove Build/Commit info and the 'i' info icon
6 participants