-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build info from management section to status page #13341
Conversation
Also closes #8225 |
I believe this was the only reason the info attribute existed on the management section, so we could clean that up as well. It's referenced in the sections.js and the landing page. |
@tylersmalley I've removed it from the |
Jenkins, test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not sure if there is anything that needs to be removed from landing.html, but it doesn't look like it to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@timroes, it's in the template here and here. The CSS styles can also be removed. |
@tylersmalley I am confused, I already removed these with my first commit here and here. I guess we kind of talked past each other here :-) I will merge this, and if there are still things left over, I would create another PR for it. |
* Move build-info to status page * Remove info property from management section
* Move build-info to status page * Remove info property from management section
As discussed in #11526 we removed the build info and its icon from the management screen, and as @uboness suggested move it to the status page.
Fixes #11526 and fixes #8225