[Security Solution][Endpoint] New endpoint policy response UI and fleet UI for integrations in agent details page #133405

dasansol92 · 2022-06-02T14:45:57Z

Summary

New endpoint policy response UI.
New UI for integrations in fleet agent details page.
Adds Needs attention button label when it's needed.
Endpoint policy response in fleet is behind a FF: policyResponseInFleetEnabled

Fleet changes without FF:

Fleet changes with FF:

Endpoint policy response changes in endpoint details flyout:

For maintainers

This was checked for breaking API changes and was labeled appropriately

…t details page

ashokaditya

This is looking awesome, so much better than what we have now 🤩 I have a couple of suggestions and mostly nits.

Also, I suggested this to @joeypoon as well on his PR. Is there a way to expand all the error item logs when you click on the needsAttention button? I think it's useful to see all the errors with a single click vs drilling down individually. Currently, it expands only the top-level accordion as seen in the PR screenshot. How about something like this below. I took a screen grab as the state persists once you drill down to inner levels.

Maybe out of scope or maybe we can do this in a new PR. Maybe we don't want to do it. Let me know what you think.

...t/sections/agents/agent_details_page/components/agent_details/agent_details_integrations.tsx

x-pack/plugins/fleet/public/types/ui_extensions.ts

...k/plugins/security_solution/public/management/components/policy_response/policy_response.tsx

...s/security_solution/public/management/components/policy_response/policy_response_wrapper.tsx

...urity_solution/public/management/components/policy_response/policy_response_wrapper.test.tsx

ashokaditya · 2022-06-03T07:56:52Z

...urity_solution/public/management/components/policy_response/policy_response_wrapper.test.tsx

+  // FIXME: for some reason it is not getting all messages items from DOM even those are rendered.
+  it.skip('should show an actions section for each configuration', async () => {
    runMock();
-    const actionAccordions = await render().findAllByTestId(
-      'endpointDetailsPolicyResponseActionsAccordion'
+    const component = await renderOpenedTree();
+
+    const configs = await component.findAllByTestId('endpointPolicyResponseConfig');
+    const actions = await component.findAllByTestId('endpointPolicyResponseAction');
+    const statusAttentionHealth = await component.findAllByTestId(
+      'endpointPolicyResponseStatusAttentionHealth'
    );
-    const action = await render().findAllByTestId('policyResponseAction');
-    const statusHealth = await render().findAllByTestId('policyResponseStatusHealth');
-    const message = await render().findAllByTestId('policyResponseMessage');
+    const statusSuccessHealth = await component.findAllByTestId(
+      'endpointPolicyResponseStatusSuccessHealth'
+    );
+    const messages = await component.findAllByTestId('endpointPolicyResponseMessage');

    let expectedActionAccordionCount = 0;
-    Object.keys(commonPolicyResponse.Endpoint.policy.applied.response.configurations).forEach(
-      (key) => {
-        expectedActionAccordionCount +=
-          commonPolicyResponse.Endpoint.policy.applied.response.configurations[
-            key as keyof HostPolicyResponse['Endpoint']['policy']['applied']['response']['configurations']
-          ].concerned_actions.length;
-      }
+    const configurationKeys = Object.keys(
+      commonPolicyResponse.Endpoint.policy.applied.response.configurations
+    );
+    configurationKeys.forEach((key) => {
+      expectedActionAccordionCount +=
+        commonPolicyResponse.Endpoint.policy.applied.response.configurations[
+          key as keyof HostPolicyResponse['Endpoint']['policy']['applied']['response']['configurations']
+        ].concerned_actions.length;
+    });
+
+    expect(configs).toHaveLength(configurationKeys.length);
+    expect(actions).toHaveLength(expectedActionAccordionCount);
+    expect(messages).toHaveLength(expectedActionAccordionCount);
+    expect([...statusSuccessHealth, ...statusAttentionHealth]).toHaveLength(
+      expectedActionAccordionCount + configurationKeys.length + 1


Looks like one of the endpointPolicyResponseStatusAttentionHealth may not be expanded here and that's why the count is off by 1. 🤷

Not exactly, the +1 here is for the top one Policy response. I'm still looking on this test

… iterate the array only one time

dasansol92 · 2022-06-03T09:16:37Z

Also, I suggested this to @joeypoon as well on his PR. Is there a way to expand all the error item logs when you click on the needsAttention button? I think it's useful to see all the errors with a single click vs drilling down individually. Currently, it expands only the top-level accordion as seen in the PR screenshot. How about something like this below. I took a screen grab as the state persists once you drill down to inner levels.

This is not possible right now because an EuiTreeView limitation. Items can be expanded only at the first render. Spoke with @kevinlog and we are ok with this by now.

ashokaditya

Thanks for the changes. 🙏 There's a color bit that needs a change.

ashokaditya · 2022-06-03T09:24:49Z

...t/sections/agents/agent_details_page/components/agent_details/agent_details_integrations.tsx

+      children: packagePolicy.inputs.reduce(
+        (acc: Array<{ label: JSX.Element; id: string }>, current) => {


Nice 🔥 . No need to change but for TS you can also do .reduce<Array<{ label: JSX.Element; id: string }>>(acc, current).

...t/sections/agents/agent_details_page/components/agent_details/agent_details_integrations.tsx

ashokaditya

Awesome! Thanks for the changes again. Looking good to 🚢!

elasticmachine · 2022-06-03T12:39:46Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

dasansol92 · 2022-06-03T12:41:23Z

@elasticmachine merge upstream

…ee_a_policy_response_section-3863

elasticmachine · 2022-06-03T12:41:34Z

Pinging @elastic/fleet (Team:Fleet)

pzl · 2022-06-03T12:41:05Z

...k/plugins/security_solution/public/management/components/policy_response/policy_response.tsx

+                    // actionButtonLabel="Do something" // TODO
+                    // actionButtonOnClick={() => {}} // TODO


This is going to be used in future pr's but is useless at this point. I can remove those comments if can create any confusion

fine to leave it in

pzl · 2022-06-03T12:41:52Z

...urity_solution/public/management/components/policy_response/policy_response_wrapper.test.tsx

+    // FIXME:  for some reason it is not getting all messages items from DOM even those are rendered.
+    // expect(messages).toHaveLength(expectedActionAccordionCount);
+    // expect([...statusSuccessHealth, ...statusAttentionHealth]).toHaveLength(
+    //   expectedActionAccordionCount + configurationKeys.length + 1
+    // );


juliaElastic

Fleet changes LGTM, could you actually see any log entries under one of the View logs links?

dasansol92 · 2022-06-03T13:31:12Z

Fleet changes LGTM, could you actually see any log entries under one of the View logs links?

@juliaElastic Thanks for taking a look! I'm using data generated by the generators. Do you have any generator I can use for that?

kibana-ci · 2022-06-03T13:47:00Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	3013	3014	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1299	1300	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	750.1KB	750.7KB	+645.0B
`securitySolution`	5.1MB	5.1MB	+816.0B
total			+1.4KB

Unknown metric groups

API count

id	before	after	diff
`fleet`	1425	1427	+2

History

💚 Build #49023 succeeded 136e7d5
💚 Build #48884 succeeded 4780ab9
💔 Build #48880 failed 380417c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

juliaElastic · 2022-06-03T13:51:41Z

Fleet changes LGTM, could you actually see any log entries under one of the View logs links?

@juliaElastic Thanks for taking a look! I'm using data generated by the generators. Do you have any generator I can use for that?

I'm not familiar with generators, do we have documentation on them?
Usually I test system logs from an elastic-agent installed locally.

joeypoon

🚀

kevinlog · 2022-06-03T17:02:14Z

@dasansol92 check it out and tried it with a real Agent/Endpoint - looks great!

I also verified @juliaElastic question - we can see logs when we navigate with real data:

kevinlog · 2022-06-03T17:02:50Z

Merged with @dasansol92 permission

New endpoint policy response UI and fleet UI for integrations in agen…

380417c

…t details page

dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.4.0 labels Jun 2, 2022

Updates multilang files

4780ab9

joeypoon mentioned this pull request Jun 2, 2022

[Security Solution] bubble up policy response errors #133349

Closed

7 tasks

ashokaditya reviewed Jun 3, 2022

View reviewed changes

dasansol92 added 5 commits June 3, 2022 10:53

Uses EuiBadge instead of EuiButton for needs attention action

d10aa05

Fixes typo and uses reduce method instead of filter + map in order to…

f5d3cf1

… iterate the array only one time

Import type directly

7166849

Adds js comment on custom css style

1b34574

Uses userEvent instead of fireEvent and removes all act functions

136e7d5

dasansol92 requested a review from ashokaditya June 3, 2022 09:18

ashokaditya reviewed Jun 3, 2022

View reviewed changes

dasansol92 added 2 commits June 3, 2022 13:08

Partially uncomment unit test

c2c9343

Use color from euiTheme hook instead of hardcoded one

c9a179d

dasansol92 requested a review from ashokaditya June 3, 2022 11:11

ashokaditya approved these changes Jun 3, 2022

View reviewed changes

dasansol92 marked this pull request as ready for review June 3, 2022 12:39

dasansol92 requested review from a team as code owners June 3, 2022 12:39

dasansol92 requested a review from pzl June 3, 2022 12:39

dasansol92 requested a review from joeypoon June 3, 2022 12:39

Merge branch 'main' into feat/olm-in_endpoint_integration_users_can_s…

4cafd07

…ee_a_policy_response_section-3863

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 3, 2022

pzl approved these changes Jun 3, 2022

View reviewed changes

juliaElastic approved these changes Jun 3, 2022

View reviewed changes

joeypoon approved these changes Jun 3, 2022

View reviewed changes

kevinlog approved these changes Jun 3, 2022

View reviewed changes

kevinlog merged commit a20cb49 into elastic:main Jun 3, 2022

kibanamachine added the backport:skip This commit does not require backporting label Jun 3, 2022

joepeeples mentioned this pull request Aug 18, 2022

[DOCS] 8.4 release notes elastic/security-docs#2314

Merged

jen-huang mentioned this pull request May 2, 2023

[Fleet] Implement per-integration health reporting #154634

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] New endpoint policy response UI and fleet UI for integrations in agent details page #133405

[Security Solution][Endpoint] New endpoint policy response UI and fleet UI for integrations in agent details page #133405

dasansol92 commented Jun 2, 2022 •

edited

Loading

ashokaditya left a comment •

edited

Loading

ashokaditya Jun 3, 2022

dasansol92 Jun 3, 2022

dasansol92 commented Jun 3, 2022

ashokaditya left a comment

ashokaditya Jun 3, 2022

ashokaditya left a comment

elasticmachine commented Jun 3, 2022

dasansol92 commented Jun 3, 2022

elasticmachine commented Jun 3, 2022

pzl Jun 3, 2022

dasansol92 Jun 3, 2022

pzl Jun 3, 2022

pzl Jun 3, 2022

juliaElastic left a comment

dasansol92 commented Jun 3, 2022 •

edited

Loading

kibana-ci commented Jun 3, 2022

API count

juliaElastic commented Jun 3, 2022

joeypoon left a comment

kevinlog commented Jun 3, 2022

kevinlog commented Jun 3, 2022

		children: packagePolicy.inputs.reduce(
		(acc: Array<{ label: JSX.Element; id: string }>, current) => {

		// actionButtonLabel="Do something" // TODO
		// actionButtonOnClick={() => {}} // TODO

[Security Solution][Endpoint] New endpoint policy response UI and fleet UI for integrations in agent details page #133405

[Security Solution][Endpoint] New endpoint policy response UI and fleet UI for integrations in agent details page #133405

Conversation

dasansol92 commented Jun 2, 2022 • edited Loading

Summary

Fleet changes without FF:

Fleet changes with FF:

Endpoint policy response changes in endpoint details flyout:

For maintainers

ashokaditya left a comment • edited Loading

Choose a reason for hiding this comment

ashokaditya Jun 3, 2022

Choose a reason for hiding this comment

dasansol92 Jun 3, 2022

Choose a reason for hiding this comment

dasansol92 commented Jun 3, 2022

ashokaditya left a comment

Choose a reason for hiding this comment

ashokaditya Jun 3, 2022

Choose a reason for hiding this comment

ashokaditya left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 3, 2022

dasansol92 commented Jun 3, 2022

elasticmachine commented Jun 3, 2022

pzl Jun 3, 2022

Choose a reason for hiding this comment

dasansol92 Jun 3, 2022

Choose a reason for hiding this comment

pzl Jun 3, 2022

Choose a reason for hiding this comment

pzl Jun 3, 2022

Choose a reason for hiding this comment

juliaElastic left a comment

Choose a reason for hiding this comment

dasansol92 commented Jun 3, 2022 • edited Loading

kibana-ci commented Jun 3, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

History

juliaElastic commented Jun 3, 2022

joeypoon left a comment

Choose a reason for hiding this comment

kevinlog commented Jun 3, 2022

kevinlog commented Jun 3, 2022

dasansol92 commented Jun 2, 2022 •

edited

Loading

ashokaditya left a comment •

edited

Loading

dasansol92 commented Jun 3, 2022 •

edited

Loading