Update new-platform dependencies. #13338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
commented
Aug 4, 2017
| export function captureTerminal<T extends string[]>( | ||
| fn: (argv: T) => any, | ||
| argv: T | ||
| ) { | ||
| const _exit = process.exit; | ||
| const _emit = process.emit; | ||
| let mockProcessExit = jest.spyOn(global.process, 'exit') |
There was a problem hiding this comment.
Well, I wouldn't touch this file at all but the problem is that in node 8 typings process.exit has never return type that is incompatible with void so it's hard to simulate in tests (it should never return). spyOn was an easy solution :)
azasypkin
commented
Aug 4, 2017
| @@ -1,7 +1,7 @@ | |||
| import { pick } from '../../../lib/utils'; | |||
|
|
|||
| export interface Headers { | |||
| [key: string]: string; | |||
| [key: string]: string | string[]; | |||
There was a problem hiding this comment.
Corresponds to new node 8 typings.
azasypkin
commented
Aug 4, 2017
| @@ -23,8 +23,8 @@ | |||
| "html" | |||
| ], | |||
| "globals": { | |||
| "__TS_CONFIG__": { | |||
There was a problem hiding this comment.
__TS_CONFIG__ is deprecated https://github.com/kulshekhar/ts-jest#tsconfig
azasypkin
force-pushed
the
issue-xxx-update-node-types
branch
from
955e394 to
080d5f4
Compare
azasypkin
force-pushed
the
issue-xxx-update-node-types
branch
from
080d5f4 to
0d2ed49
Compare
|
Okay, there is no any movement in the node issue mentioned above, so I'll merge this PR and keep tracking that issue for any updates. |
kimjoar
added
the
Team:Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes in the source code are caused by node 8 typings.
I won't merge this PR until it's clear what to do with
defaultEncoding, see bug I filed nodejs/node#14611. Same thing is related to node 6, i.e. master branch./cc @kjbekkelund