Duration Formatting for TSVB #13337
Merged
Duration Formatting for TSVB #13337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:TSVB
|
Fixes #12718 |
| }); | ||
| }; | ||
| } | ||
|
|
||
| render() { |
There was a problem hiding this comment.
there's somewhat of a weird issue where the duration option becomes unavailable.
Steps:
- just use default chart (default Count metric)
- in options, select the duration Data Formatter
- change some settings (e.g format from weeks to milliseconds)
- remove the decimal places entry so the textbox is empty -> the form bounces back to the
customdata formatter. - try and go back to the Duration Formatter -> it won't let you, always bouncing back to the default
customdata formatter
There was a problem hiding this comment.
I think I addressed this with relaxing the duration format test.
thomasneirynck
approved these changes
Aug 18, 2017
simianhacker
added a commit
that referenced
this pull request
Aug 18, 2017
* Adding duration formatter * Adding decimal places * Fixing bug with decimals * Relaxing the duration format test
simianhacker
added a commit
that referenced
this pull request
Aug 18, 2017
* Adding duration formatter * Adding decimal places * Fixing bug with decimals * Relaxing the duration format test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds duration formatting to TSVB