[Accessibilty] Make kbn_accessible_click part of autoload/all #13299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
Aug 2, 2017
|
I tested all the links in Discover, Timelion, and Dashboard and they still function with keyboard accessibility. |
|
Thank you, reviewers! |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 3, 2017
…c#13299) * [Accessibility] Ensure kbn-accessible-click is part of autoload/all * remove unecessary kbn_accessible_click imports * use an index.js file to expose inner directives
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 3, 2017
…c#13299) * [Accessibility] Ensure kbn-accessible-click is part of autoload/all * remove unecessary kbn_accessible_click imports * use an index.js file to expose inner directives
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 3, 2017
…c#13299) * [Accessibility] Ensure kbn-accessible-click is part of autoload/all * remove unecessary kbn_accessible_click imports * use an index.js file to expose inner directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins that use
autoload/allweren't getting the advantage of having thekbn_accessible_clickdirective. This adds that directive to be loaded, and also removes some unnecessary imports of that directive.