[ML] @kbn/ml-agg-utils, @kbn/ml-is-populated-object, @kbn/ml-string-hash packages.

[walterra]

Summary

Part of #136265.

Moves some ML utility code to packages.

• @kbn/ml-agg-utils contains multiple utilities used in combination related to building aggregations.
• @kbn/ml-is-populated-object contains the isPopulatedObject() utility function used across several plugins.
• @kbn/ml-string-hash contains the stringHash() utility function used across several plugins.

This is in preparation for this code also to be consumed by the aiops plugin.

Checklist

• Documentation was added for features that require explanation or tutorials
• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[spalger]

👍 Nice!

[qn895]

For future follow ups: Since we are making this utility generic now, I think we should be able to pass in an optional maxChartColumns arg with MAX_CHART_COLUMNS as fallback so it's not so opinionated.

[nreese]

file_upload changes LGTM
code review

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 138a51f
• Storybooks Preview
• Webpack Bundle Analyzer

Failed CI Steps

• FTR Configs #22

Test Failures

• [job] [logs] FTR Configs #22 / Kibana Tags Page Accessibility tag assignment panel meets a11y requirements

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dataVisualizer	351	363	+12
fileUpload	177	178	+1
ml	1615	1619	+4
transform	303	307	+4
total			+21

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
ml	81	78	-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dataVisualizer	537.1KB	543.5KB	+6.4KB
fileUpload	813.2KB	813.5KB	+357.0B
ml	3.3MB	3.3MB	+1.1KB
transform	371.8KB	373.2KB	+1.4KB
total			+9.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
ml	40.3KB	40.3KB	+28.0B

Unknown metric groups

API count

id	before	after	diff
ml	254	251	-3

ESLint disabled line counts

id	before	after	diff
dataVisualizer	38	36	-2
ml	105	103	-2
transform	26	24	-2
total			-6

Total ESLint disabled count

id	before	after	diff
dataVisualizer	38	36	-2
ml	108	106	-2
transform	29	27	-2
total			-6

History

• 💚 Build #52087 succeeded d657ce4
• 💚 Build #52060 succeeded 7ef9146be95084d6db81bf70350052924327a4d7
• 💔 Build #52050 failed 09cfe7276dd8674ff5a01877bdb78c422e667e6b
• 💔 Build #52040 failed bafadefb63505b805a87b2fb6af3dee7340f18c9
• 💔 Build #47716 failed 3ed02f4ef6275844f16f72f08e59e3bedea1be0a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

[walterra]

@qn895 This is ready for another look. I moved stringHash to its own package too and renamed data-utils to agg-utils to make it more specific. This further improved bundle sizes.

[qn895]

Latest code changes LGTM 🎉