Use find service instead of remote #13296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
force-pushed
the
tests/stabilize-dashboard-tests-2
branch
from
b48a2e5 to
4e3ad2b
Compare
… checks for stale elements
stacey-gammon
force-pushed
the
tests/stabilize-dashboard-tests-2
branch
from
79fd9bc to
937186d
Compare
stacey-gammon
force-pushed
the
tests/stabilize-dashboard-tests-2
branch
from
6877761 to
728f8d2
Compare
Added some extra functionality for this in find and testSubjects service, and using in the one place it’s required.
|
Passed once, jenkins test this |
|
Passed twice Jenkins, test this |
|
Passed three times. I think that's sufficient. |
…/stabilize-dashboard-tests-2
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 8, 2017
* Use find service instead of remote which doesn't have built in safety checks for stale elements * use data-test-subj instead of id * add missing function and awaits * Did not realize WebElements could find descendants Added some extra functionality for this in find and testSubjects service, and using in the one place it’s required.
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 8, 2017
* Use find service instead of remote which doesn't have built in safety checks for stale elements * use data-test-subj instead of id * add missing function and awaits * Did not realize WebElements could find descendants Added some extra functionality for this in find and testSubjects service, and using in the one place it’s required.
This was referenced Aug 8, 2017
stacey-gammon
added a commit
that referenced
this pull request
Aug 8, 2017
* Use find service instead of remote which doesn't have built in safety checks for stale elements * use data-test-subj instead of id * add missing function and awaits * Did not realize WebElements could find descendants Added some extra functionality for this in find and testSubjects service, and using in the one place it’s required.
stacey-gammon
added a commit
that referenced
this pull request
Aug 8, 2017
* Use find service instead of remote which doesn't have built in safety checks for stale elements * use data-test-subj instead of id * add missing function and awaits * Did not realize WebElements could find descendants Added some extra functionality for this in find and testSubjects service, and using in the one place it’s required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find service has built in checks for stale elements and such.
Fixes #13289